juni/crystall-punk-14
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor ExaminableDamage (#38978)

Browse Source 
* Remove prototype caching in ExaminableDamageComponent

* Replace ExaminableDamagePrototype with LocalizedDatasetPrototype

* Allow null
This commit is contained in:
Tayrtahn
2025-07-14 00:35:47 -04:00
committed by GitHub
parent bd2212beff
commit 4f766f199c
4 changed files with 34 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

62
Content.Server/Damage/Systems/ExaminableDamageSystem.cs
View File

@@ -1,9 +1,6 @@
using System.Linq;
using Content.Server.Damage.Components;
using Content.Server.Damage.Components;
using Content.Server.Destructible;
using Content.Server.Destructible.Thresholds.Triggers;
using Content.Shared.Damage;
using Content.Shared.Damage.Prototypes;
using Content.Shared.Examine;
using Content.Shared.Rounding;
using Robust.Shared.Prototypes;
@@ -12,59 +9,42 @@ namespace Content.Server.Damage.Systems;
public sealed class ExaminableDamageSystem : EntitySystem
{
[Dependency] private readonly DestructibleSystem _destructible = default!;
[Dependency] private readonly IPrototypeManager _prototype = default!;
public override void Initialize()
{
base.Initialize();
SubscribeLocalEvent<ExaminableDamageComponent, ComponentInit>(OnInit);
SubscribeLocalEvent<ExaminableDamageComponent, ExaminedEvent>(OnExamine);
}
private void OnInit(EntityUid uid, ExaminableDamageComponent component, ComponentInit args)
private void OnExamine(Entity<ExaminableDamageComponent> ent, ref ExaminedEvent args)
{
if (component.MessagesProtoId == null)
if (!_prototype.TryIndex(ent.Comp.Messages, out var proto) || proto.Values.Count == 0)
return;
component.MessagesProto = _prototype.Index<ExaminableDamagePrototype>(component.MessagesProtoId);
var percent = GetDamagePercent(ent);
var level = ContentHelpers.RoundToNearestLevels(percent, 1, proto.Values.Count - 1);
var msg = Loc.GetString(proto.Values[level]);
args.PushMarkup(msg, -99);
}
private void OnExamine(EntityUid uid, ExaminableDamageComponent component, ExaminedEvent args)
/// <summary>
/// Returns a value between 0 and 1 representing how damaged the entity is,
/// where 0 is undamaged and 1 is fully damaged.
/// </summary>
/// <returns>How damaged the entity is from 0 to 1</returns>
private float GetDamagePercent(Entity<ExaminableDamageComponent> ent)
{
if (component.MessagesProto == null)
return;
var messages = component.MessagesProto.Messages;
if (messages.Length == 0)
return;
var level = GetDamageLevel(uid, component);
var msg = Loc.GetString(messages[level]);
args.PushMarkup(msg,-99);
}
private int GetDamageLevel(EntityUid uid, ExaminableDamageComponent? component = null,
DamageableComponent? damageable = null, DestructibleComponent? destructible = null)
{
if (!Resolve(uid, ref component, ref damageable, ref destructible))
return 0;
if (component.MessagesProto == null)
return 0;
var maxLevels = component.MessagesProto.Messages.Length - 1;
if (maxLevels <= 0)
return 0;
var trigger = (DamageTrigger?) destructible.Thresholds
.LastOrDefault(threshold => threshold.Trigger is DamageTrigger)?.Trigger;
if (trigger == null)
if (!TryComp<DamageableComponent>(ent, out var damageable))
return 0;
var damage = damageable.TotalDamage;
var damageThreshold = trigger.Damage;
var fraction = damageThreshold == 0 ? 0f : (float) damage / damageThreshold;
var damageThreshold = _destructible.DestroyedAt(ent);
var level = ContentHelpers.RoundToNearestLevels(fraction, 1, maxLevels);
return level;
if (damageThreshold == 0)
return 0;
return (damage / damageThreshold).Float();
}
}