From 62cdf9e1c5d9532c022ef6120a4f35db484fac7e Mon Sep 17 00:00:00 2001 From: Ed <96445749+TheShuEd@users.noreply.github.com> Date: Fri, 25 Apr 2025 13:39:20 +0300 Subject: [PATCH] Bugfixes + QoL (#1218) * fix keyring * fix #1209 * fix #1116 * fix water, test reenable ambient loop * recipe categories in workbecnhes * Update CP14StoreWindow.xaml * refactor: review * Update CP14WorkbenchWindow.xaml.cs * Update SharedCP14MagicEnergySystem.cs * categorizize all recipes + some UI fix * Update round_end.yml --------- Co-authored-by: Tornado Tech <54727692+Tornado-Technology@users.noreply.github.com> --- .../ContentAudioSystem.CP14AmbientLoop.cs | 3 - .../CP14ClientModularCraftSystem.cs | 5 +- .../TravelingStoreShip/CP14StoreWindow.xaml | 4 +- .../CP14WorkbenchBoundUserInterface.cs | 11 +- .../_CP14/Workbench/CP14WorkbenchWindow.xaml | 11 +- .../Workbench/CP14WorkbenchWindow.xaml.cs | 204 +++++++++++++----- .../_CP14/LockKey/SharedCP14LockKeySystem.cs | 8 +- .../SharedCP14MagicEnergySystem.cs | 7 + .../_CP14/Workbench/CP14WorkbenchUI.cs | 15 ++ .../CP14WorkbenchRecipeCategoryPrototype.cs | 18 ++ .../CP14WorkbenchRecipePrototype.cs | 3 + .../en-US/_CP14/workbench/categories.ftl | 6 + .../ru-RU/_CP14/workbench/categories.ftl | 6 + .../Entities/Structures/Floor/floorWater.yml | 9 +- .../Specific/Thaumaturgy/round_end.yml | 1 - .../_CP14/Recipes/Workbench/Anvil/misc.yml | 34 ++- .../Workbench/Anvil/modular_aventail.yml | 8 + .../Recipes/Workbench/Anvil/modular_blade.yml | 54 ++++- .../Workbench/Anvil/modular_breastplate.yml | 12 ++ .../Workbench/Anvil/modular_cuisses.yml | 8 + .../Recipes/Workbench/Anvil/modular_garde.yml | 8 + .../Workbench/Anvil/modular_greave.yml | 8 + .../Workbench/Anvil/modular_helmet.yml | 8 + .../Recipes/Workbench/Anvil/modular_tip.yml | 4 + .../Recipes/Workbench/Anvil/modular_visor.yml | 8 + .../Recipes/Workbench/Workbench/misc.yml | 9 + .../Recipes/Workbench/Workbench/tile.yml | 15 ++ .../_CP14/Recipes/Workbench/categories.yml | 15 ++ 28 files changed, 416 insertions(+), 86 deletions(-) create mode 100644 Content.Shared/_CP14/Workbench/Prototypes/CP14WorkbenchRecipeCategoryPrototype.cs create mode 100644 Resources/Locale/en-US/_CP14/workbench/categories.ftl create mode 100644 Resources/Locale/ru-RU/_CP14/workbench/categories.ftl create mode 100644 Resources/Prototypes/_CP14/Recipes/Workbench/categories.yml diff --git a/Content.Client/Audio/ContentAudioSystem.CP14AmbientLoop.cs b/Content.Client/Audio/ContentAudioSystem.CP14AmbientLoop.cs index ef7726048d..80e6e96e43 100644 --- a/Content.Client/Audio/ContentAudioSystem.CP14AmbientLoop.cs +++ b/Content.Client/Audio/ContentAudioSystem.CP14AmbientLoop.cs @@ -43,14 +43,11 @@ public sealed partial class ContentAudioSystem private void CP14UpdateAmbientLoops() { - return; //DISABLED UNTIL CLIENT ERROR SPAM FIXED - if (_timing.CurTime <= _nextUpdateTime) return; _nextUpdateTime = _timing.CurTime + _updateFrequency; - if (_state.CurrentState is not GameplayState) return; diff --git a/Content.Client/_CP14/ModularCraft/CP14ClientModularCraftSystem.cs b/Content.Client/_CP14/ModularCraft/CP14ClientModularCraftSystem.cs index fd7b080f79..40b1b5dc00 100644 --- a/Content.Client/_CP14/ModularCraft/CP14ClientModularCraftSystem.cs +++ b/Content.Client/_CP14/ModularCraft/CP14ClientModularCraftSystem.cs @@ -170,7 +170,6 @@ public sealed class CP14ClientModularCraftSystem : CP14SharedModularCraftSystem var defaultKey = $"cp14-modular-clothing-layer-{args.Slot}"; - var counterPart = 0; foreach (var part in start.Comp.InstalledParts) { var indexedPart = _proto.Index(part); @@ -180,7 +179,7 @@ public sealed class CP14ClientModularCraftSystem : CP14SharedModularCraftSystem var i = 0; foreach (var layer in layers) { - var key = $"{defaultKey}-{counterPart}-{i}"; + var key = $"{defaultKey}-{indexedPart.ID}-{i}"; args.Layers.Add((key, layer)); i++; } @@ -210,7 +209,7 @@ public sealed class CP14ClientModularCraftSystem : CP14SharedModularCraftSystem Color = indexedPart.Color, }; - var key = $"{defaultKey}-{counterPart}-default"; + var key = $"{defaultKey}-{indexedPart.ID}-default"; args.Layers.Add((key, defaultLayer)); } } diff --git a/Content.Client/_CP14/TravelingStoreShip/CP14StoreWindow.xaml b/Content.Client/_CP14/TravelingStoreShip/CP14StoreWindow.xaml index 76bbff5b96..9a80eed09f 100644 --- a/Content.Client/_CP14/TravelingStoreShip/CP14StoreWindow.xaml +++ b/Content.Client/_CP14/TravelingStoreShip/CP14StoreWindow.xaml @@ -7,7 +7,7 @@ - + @@ -16,7 +16,7 @@ - +