Action charges refactor (#33993)

* Action charges refactor - Fixes the slight godmoding of baseactioncomponent. - Gets back 1ms of server time. * chorg * Remove FrameUpdate * Fixes * More fixes * Combine * Fixes * Updates * weh * Last fixes * weh * Fix naughty * YAML fixes * This one too * Merge conflicts * This thing * Review * Fix this as well * Icon fix * weh * Review * Review * seamless * Review
2025-04-18 13:45:48 +10:00
parent 424f153142
commit 7d2ef2bd47
30 changed files with 366 additions and 399 deletions
--- a/Content.Client/Charges/ChargesSystem.cs
+++ b/Content.Client/Charges/ChargesSystem.cs
@@ -0,0 +1,52 @@
+using Content.Client.Actions;
+using Content.Shared.Actions;
+using Content.Shared.Charges.Components;
+using Content.Shared.Charges.Systems;
+
+namespace Content.Client.Charges;
+
+public sealed class ChargesSystem : SharedChargesSystem
+{
+    [Dependency] private readonly ActionsSystem _actions = default!;
+
+    private Dictionary<EntityUid, int> _lastCharges = new();
+    private Dictionary<EntityUid, int> _tempLastCharges = new();
+
+    public override void Update(float frameTime)
+    {
+        // Technically this should probably be in frameupdate but no one will ever notice a tick of delay on this.
+        base.Update(frameTime);
+
+        if (!_timing.IsFirstTimePredicted)
+            return;
+
+        // Update recharging actions. Server doesn't actually care about this and it's a waste of performance, actions are immediate.
+        var query = AllEntityQuery<AutoRechargeComponent, LimitedChargesComponent>();
+
+        while (query.MoveNext(out var uid, out var recharge, out var charges))
+        {
+            BaseActionComponent? actionComp = null;
+
+            if (!_actions.ResolveActionData(uid, ref actionComp, logError: false))
+                continue;
+
+            var current = GetCurrentCharges((uid, charges, recharge));
+
+            if (!_lastCharges.TryGetValue(uid, out var last) || current != last)
+            {
+                _actions.UpdateAction(uid, actionComp);
+            }
+
+            _tempLastCharges[uid] = current;
+        }
+
+        _lastCharges.Clear();
+
+        foreach (var (uid, value) in _tempLastCharges)
+        {
+            _lastCharges[uid] = value;
+        }
+
+        _tempLastCharges.Clear();
+    }
+}