Action charges refactor (#33993)

* Action charges refactor

- Fixes the slight godmoding of baseactioncomponent.
- Gets back 1ms of server time.

* chorg

* Remove FrameUpdate

* Fixes

* More fixes

* Combine

* Fixes

* Updates

* weh

* Last fixes

* weh

* Fix naughty

* YAML fixes

* This one too

* Merge conflicts

* This thing

* Review

* Fix this as well

* Icon fix

* weh

* Review

* Review

* seamless

* Review

Content.Server/Charges/ChargesSystem.cs

@@ -0,0 +1,8 @@
+using Content.Shared.Charges.Systems;
+
+namespace Content.Server.Charges;
+
+public sealed class ChargesSystem : SharedChargesSystem
+{
+
+}

Content.Server/Charges/Components/AutoRechargeComponent.cs

@@ -1,27 +0,0 @@
-using Content.Server.Charges.Systems;
-using Robust.Shared.Serialization.TypeSerializers.Implementations.Custom;
-
-namespace Content.Server.Charges.Components;
-
-/// <summary>
-/// Something with limited charges that can be recharged automatically.
-/// Requires LimitedChargesComponent to function.
-/// </summary>
-// TODO: no reason this cant be predicted and server system deleted
-[RegisterComponent, AutoGenerateComponentPause]
-[Access(typeof(ChargesSystem))]
-public sealed partial class AutoRechargeComponent : Component
-{
-    /// <summary>
-    /// The time it takes to regain a single charge
-    /// </summary>
-    [DataField("rechargeDuration"), ViewVariables(VVAccess.ReadWrite)]
-    public TimeSpan RechargeDuration = TimeSpan.FromSeconds(90);
-
-    /// <summary>
-    /// The time when the next charge will be added
-    /// </summary>
-    [DataField("nextChargeTime", customTypeSerializer: typeof(TimeOffsetSerializer))]
-    [AutoPausedField]
-    public TimeSpan NextChargeTime;
-}

Content.Server/Charges/Systems/ChargesSystem.cs

@@ -1,53 +0,0 @@
-using Content.Server.Charges.Components;
-using Content.Shared.Charges.Components;
-using Content.Shared.Charges.Systems;
-using Content.Shared.Examine;
-using Robust.Shared.Timing;
-
-namespace Content.Server.Charges.Systems;
-
-public sealed class ChargesSystem : SharedChargesSystem
-{
-    [Dependency] private readonly IGameTiming _timing = default!;
-
-    public override void Update(float frameTime)
-    {
-        base.Update(frameTime);
-
-        var query = EntityQueryEnumerator<LimitedChargesComponent, AutoRechargeComponent>();
-        while (query.MoveNext(out var uid, out var charges, out var recharge))
-        {
-            if (charges.Charges == charges.MaxCharges || _timing.CurTime < recharge.NextChargeTime)
-                continue;
-
-            AddCharges(uid, 1, charges);
-            recharge.NextChargeTime = _timing.CurTime + recharge.RechargeDuration;
-        }
-    }
-
-    protected override void OnExamine(EntityUid uid, LimitedChargesComponent comp, ExaminedEvent args)
-    {
-        base.OnExamine(uid, comp, args);
-
-        // only show the recharging info if it's not full
-        if (!args.IsInDetailsRange || comp.Charges == comp.MaxCharges || !TryComp<AutoRechargeComponent>(uid, out var recharge))
-            return;
-
-        var timeRemaining = Math.Round((recharge.NextChargeTime - _timing.CurTime).TotalSeconds);
-        args.PushMarkup(Loc.GetString("limited-charges-recharging", ("seconds", timeRemaining)));
-    }
-
-    public override void AddCharges(EntityUid uid, int change, LimitedChargesComponent? comp = null)
-    {
-        if (!Query.Resolve(uid, ref comp, false))
-            return;
-
-        var startRecharge = comp.Charges == comp.MaxCharges;
-        base.AddCharges(uid, change, comp);
-
-        // if a charge was just used from full, start the recharge timer
-        // TODO: probably make this an event instead of having le server system that just does this
-        if (change < 0 && startRecharge && TryComp<AutoRechargeComponent>(uid, out var recharge))
-            recharge.NextChargeTime = _timing.CurTime + recharge.RechargeDuration;
-    }
-}

Content.Server/Flash/FlashSystem.cs

@@ -29,7 +29,7 @@ namespace Content.Server.Flash
     {
         [Dependency] private readonly AppearanceSystem _appearance = default!;
         [Dependency] private readonly AudioSystem _audio = default!;
-        [Dependency] private readonly SharedChargesSystem _charges = default!;
+        [Dependency] private readonly SharedChargesSystem _sharedCharges = default!;
         [Dependency] private readonly EntityLookupSystem _entityLookup = default!;
         [Dependency] private readonly SharedTransformSystem _transform = default!;
         [Dependency] private readonly ExamineSystemShared _examine = default!;
@@ -86,15 +86,15 @@ namespace Content.Server.Flash
                 return false;
 
             TryComp<LimitedChargesComponent>(uid, out var charges);
-            if (_charges.IsEmpty(uid, charges))
+            if (_sharedCharges.IsEmpty((uid, charges)))
                 return false;
 
-            _charges.UseCharge(uid, charges);
+            _sharedCharges.TryUseCharge((uid, charges));
             _audio.PlayPvs(comp.Sound, uid);
             comp.Flashing = true;
             _appearance.SetData(uid, FlashVisuals.Flashing, true);
 
-            if (_charges.IsEmpty(uid, charges))
+            if (_sharedCharges.IsEmpty((uid, charges)))
             {
                 _appearance.SetData(uid, FlashVisuals.Burnt, true);
                 _tag.AddTag(uid, TrashTag);