Action charges refactor (#33993)

* Action charges refactor

- Fixes the slight godmoding of baseactioncomponent.
- Gets back 1ms of server time.

* chorg

* Remove FrameUpdate

* Fixes

* More fixes

* Combine

* Fixes

* Updates

* weh

* Last fixes

* weh

* Fix naughty

* YAML fixes

* This one too

* Merge conflicts

* This thing

* Review

* Fix this as well

* Icon fix

* weh

* Review

* Review

* seamless

* Review

Content.Shared/Actions/BaseActionComponent.cs

@@ -86,24 +86,6 @@ public abstract partial class BaseActionComponent : Component
     /// </summary>
     [DataField("useDelay")] public TimeSpan? UseDelay;
 
-    /// <summary>
-    ///     Convenience tool for actions with limited number of charges. Automatically decremented on use, and the
-    ///     action is disabled when it reaches zero. Does NOT automatically remove the action from the action bar.
-    ///     However, charges will regenerate if <see cref="RenewCharges"/> is enabled and the action will not disable
-    ///     when charges reach zero.
-    /// </summary>
-    [DataField("charges")] public int? Charges;
-
-    /// <summary>
-    ///     The max charges this action has. If null, this is set automatically from <see cref="Charges"/> on mapinit.
-    /// </summary>
-    [DataField] public int? MaxCharges;
-
-    /// <summary>
-    ///     If enabled, charges will regenerate after a <see cref="Cooldown"/> is complete
-    /// </summary>
-    [DataField("renewCharges")]public bool RenewCharges;
-
     /// <summary>
     /// The entity that contains this action. If the action is innate, this may be the user themselves.
     /// This should almost always be non-null.
@@ -209,9 +191,6 @@ public abstract class BaseActionComponentState : ComponentState
     public bool Toggled;
     public (TimeSpan Start, TimeSpan End)? Cooldown;
     public TimeSpan? UseDelay;
-    public int? Charges;
-    public int? MaxCharges;
-    public bool RenewCharges;
     public NetEntity? Container;
     public NetEntity? EntityIcon;
     public bool CheckCanInteract;
@@ -243,9 +222,6 @@ public abstract class BaseActionComponentState : ComponentState
         Toggled = component.Toggled;
         Cooldown = component.Cooldown;
         UseDelay = component.UseDelay;
-        Charges = component.Charges;
-        MaxCharges = component.MaxCharges;
-        RenewCharges = component.RenewCharges;
         CheckCanInteract = component.CheckCanInteract;
         CheckConsciousness = component.CheckConsciousness;
         ClientExclusive = component.ClientExclusive;