Action charges refactor (#33993)

* Action charges refactor

- Fixes the slight godmoding of baseactioncomponent.
- Gets back 1ms of server time.

* chorg

* Remove FrameUpdate

* Fixes

* More fixes

* Combine

* Fixes

* Updates

* weh

* Last fixes

* weh

* Fix naughty

* YAML fixes

* This one too

* Merge conflicts

* This thing

* Review

* Fix this as well

* Icon fix

* weh

* Review

* Review

* seamless

* Review

Resources/Prototypes/Actions/types.yml

@@ -93,8 +93,9 @@
   name: Break Free
   description: Activating your freedom implant will free you from any hand restraints
   components:
+  - type: LimitedCharges
+    maxCharges: 3
   - type: InstantAction
-    charges: 3
     checkCanInteract: false
     itemIconStyle: BigAction
     priority: -20
@@ -121,9 +122,10 @@
   name: Activate EMP
   description: Triggers a small EMP pulse around you
   components:
+  - type: LimitedCharges
+    maxCharges: 3
   - type: InstantAction
     checkCanInteract: false
-    charges: 3
     useDelay: 5
     itemIconStyle: BigAction
     priority: -20
@@ -137,9 +139,10 @@
   name: SCRAM!
   description: Randomly teleports you within a large distance.
   components:
+  - type: LimitedCharges
+    maxCharges: 2
   - type: InstantAction
     checkCanInteract: false
-    charges: 2
     useDelay: 5
     itemIconStyle: BigAction
     priority: -20
@@ -155,8 +158,9 @@
   components:
   - type: ConfirmableAction
     popup: dna-scrambler-action-popup
+  - type: LimitedCharges
+    maxCharges: 1
   - type: InstantAction
-    charges: 1
     itemIconStyle: BigAction
     priority: -20
     icon:

Resources/Prototypes/Entities/Objects/Misc/fluff_lights.yml

@@ -159,7 +159,6 @@
   - type: Flash
   - type: LimitedCharges
     maxCharges: 3
-    charges: 3
   - type: AutoRecharge
     rechargeDuration: 30
   - type: MeleeWeapon

Resources/Prototypes/Entities/Objects/Tools/lantern.yml

@@ -88,7 +88,6 @@
     - type: Flash
     - type: LimitedCharges
       maxCharges: 15
-      charges: 15
     - type: MeleeWeapon
       damage:
         types:

Resources/Prototypes/Entities/Objects/Tools/tools.yml

@@ -320,7 +320,6 @@
     - Deconstruct
   - type: LimitedCharges
     maxCharges: 30
-    charges: 30
   - type: Sprite
     sprite: Objects/Tools/rcd.rsi
     state: icon
@@ -351,7 +350,7 @@
   suffix: Empty
   components:
   - type: LimitedCharges
-    charges: 0
+    lastCharges: -1
 
 - type: entity
   id: RCDRecharging
@@ -362,7 +361,6 @@
   components:
   - type: LimitedCharges
     maxCharges: 20
-    charges: 20
   - type: AutoRecharge
     rechargeDuration: 10
 

Resources/Prototypes/Entities/Objects/Weapons/Melee/sword.yml

@@ -89,7 +89,6 @@
   - type: DashAbility
   - type: LimitedCharges
     maxCharges: 3
-    charges: 3
   - type: AutoRecharge
     rechargeDuration: 20
   - type: Clothing

Resources/Prototypes/Entities/Objects/Weapons/security.yml

@@ -147,7 +147,6 @@
     - type: Flash
     - type: LimitedCharges
       maxCharges: 5
-      charges: 5
     - type: MeleeWeapon
       wideAnimationRotation: 180
       damage:
@@ -183,7 +182,6 @@
   components:
     - type: LimitedCharges
       maxCharges: 2
-      charges: 2
 
 - type: entity
   name: portable flasher

Resources/Prototypes/Magic/animate_spell.yml

@@ -3,9 +3,10 @@
   name: Animate
   description: Bring an inanimate object to life!
   components:
+  - type: LimitedCharges
+    maxCharges: 5
   - type: EntityTargetAction
     useDelay: 0
-    charges: 5
     itemIconStyle: BigAction
     whitelist:
       components:

Resources/Prototypes/Magic/projectile_spells.yml

@@ -30,8 +30,6 @@
   description: Fires a fireball, but faster!
   components:
   - type: WorldTargetAction
-    useDelay: 10
-    renewCharges: true
     itemIconStyle: BigAction
     checkCanAccess: false
     raiseOnUser: true
@@ -52,8 +50,6 @@
   description: The fastest fireball in the west!
   components:
     - type: WorldTargetAction
-      useDelay: 8
-      renewCharges: true
       itemIconStyle: BigAction
       checkCanAccess: false
       raiseOnUser: true

Resources/Prototypes/Magic/staves.yml

@@ -59,9 +59,10 @@
 - type: entity
   id: ActionRgbLight
   components:
+  - type: LimitedCharges
+    maxCharges: 25
   - type: EntityTargetAction
     whitelist: { components: [ PointLight ] }
-    charges: 25
     sound: /Audio/Magic/blink.ogg
     event: !type:ChangeComponentsSpellEvent
       toAdd: