diff --git a/.editorconfig b/.editorconfig index 8a5cf43521..a87e5e0651 100644 --- a/.editorconfig +++ b/.editorconfig @@ -77,6 +77,8 @@ csharp_style_expression_bodied_methods = false:suggestion #csharp_style_expression_bodied_operators = false:silent csharp_style_expression_bodied_properties = true:suggestion +csharp_style_namespace_declarations = file_scoped:suggestion + # Pattern matching preferences #csharp_style_pattern_matching_over_as_with_null_check = true:suggestion #csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion diff --git a/Content.Benchmarks/SpawnEquipDeleteBenchmark.cs b/Content.Benchmarks/SpawnEquipDeleteBenchmark.cs index 0638d945aa..9b878eac40 100644 --- a/Content.Benchmarks/SpawnEquipDeleteBenchmark.cs +++ b/Content.Benchmarks/SpawnEquipDeleteBenchmark.cs @@ -8,6 +8,7 @@ using Robust.Shared; using Robust.Shared.Analyzers; using Robust.Shared.GameObjects; using Robust.Shared.Map; +using Robust.Shared.Prototypes; namespace Content.Benchmarks; @@ -18,9 +19,11 @@ namespace Content.Benchmarks; [Virtual, MemoryDiagnoser] public class SpawnEquipDeleteBenchmark { + private static readonly EntProtoId Mob = "MobHuman"; + private static readonly ProtoId CaptainStartingGear = "CaptainGear"; + private TestPair _pair = default!; private StationSpawningSystem _spawnSys = default!; - private const string Mob = "MobHuman"; private StartingGearPrototype _gear = default!; private EntityUid _entity; private EntityCoordinates _coords; @@ -39,7 +42,7 @@ public class SpawnEquipDeleteBenchmark var mapData = await _pair.CreateTestMap(); _coords = mapData.GridCoords; _spawnSys = server.System(); - _gear = server.ProtoMan.Index("CaptainGear"); + _gear = server.ProtoMan.Index(CaptainStartingGear); } [GlobalCleanup] diff --git a/Content.Client/Access/UI/GroupedAccessLevelChecklist.xaml.cs b/Content.Client/Access/UI/GroupedAccessLevelChecklist.xaml.cs index da68653ce5..4f07c31009 100644 --- a/Content.Client/Access/UI/GroupedAccessLevelChecklist.xaml.cs +++ b/Content.Client/Access/UI/GroupedAccessLevelChecklist.xaml.cs @@ -15,6 +15,8 @@ namespace Content.Client.Access.UI; [GenerateTypedNameReferences] public sealed partial class GroupedAccessLevelChecklist : BoxContainer { + private static readonly ProtoId GeneralAccessGroup = "General"; + [Dependency] private readonly IPrototypeManager _protoManager = default!; private bool _isMonotone; @@ -63,7 +65,7 @@ public sealed partial class GroupedAccessLevelChecklist : BoxContainer // Ensure that the 'general' access group is added to handle // misc. access levels that aren't associated with any group - if (_protoManager.TryIndex("General", out var generalAccessProto)) + if (_protoManager.TryIndex(GeneralAccessGroup, out var generalAccessProto)) _groupedAccessLevels.TryAdd(generalAccessProto, new()); // Assign known access levels with their associated groups diff --git a/Content.Client/Administration/UI/ManageSolutions/EditSolutionsWindow.xaml b/Content.Client/Administration/UI/ManageSolutions/EditSolutionsWindow.xaml index 01259b60f7..6146240824 100644 --- a/Content.Client/Administration/UI/ManageSolutions/EditSolutionsWindow.xaml +++ b/Content.Client/Administration/UI/ManageSolutions/EditSolutionsWindow.xaml @@ -8,6 +8,21 @@ + +