* added generic Entity Effects status effect component
* added Magic Vision Statuseffect component
* renamed visionmask to Visibilitymask and added StatusEffectComponent notice comment
* added two event listeners on MagicVisonStatusEffect applied and removed
* moved changes to server side
* moved Component serverside
* removed Overlay Property
* Added magic vison status effect prototype and applying
* cleaned upnew lines
* added new prototype
* moved Magic vision status effect component to shared again
* fixed applying mask
* cleaned new lines
* Moved to components folder
* marked MagicVisionComponent obsolete and changed protoid name
* Added parent MobStatusEffectBase
* added mana cost to Magical vision spell
* removed unneeded constructor
* Added the system
* added statuseffect eventlistners for applied and removed also removed old event listners
* removed old magic vision component check
* Removed Data field attribute
* added back Data field attribute
* added access atribute
* moved Status effect update to server
* removed shared System moved all to server side
* Update Content.Shared/_CP14/StatusEffect/Components/CP14EntityEffectsStatusEffectComponent.cs
Co-authored-by: Red <96445749+TheShuEd@users.noreply.github.com>
* Fix typo in DataField attribute for Effects list
* Obliterated CP14MagicVisionComponent from existence
* Fix comment capitalization in CP14EntityEffectsStatusEffectComponent
* Fix summary capitalization in CP14EntityEffectsStatusEffectComponent
* Refactor CP14MagicVisionSystem.cs by removing blank lines
Removed unnecessary blank lines for cleaner code.
* Remove status effect event handlers
Removed event subscription and related methods for status effects.
* Remove empty line in OnExamined method
* Added a Spell toggle status effect
* fixed datfields shouldnt be static
* imlpemented status applying in yml
* cleaned white space :3
* changed toggle to has status effect
* fix leftover
* added check for firsttime predict so it doesnt get applied twice
* added getvismaskevent to statuseffect relay
* changed event lisnter to use CP14MagicVisionStatusEffectComponent to prevent future conflicts
* removed unneeded _status property
* added check for if its the last status effect on remove
* added check if Status effect is already present if applied
* changed check to component instead of entity
* changed ent target to player.localEntity
* fix: removed has effect check as it already has the effect when first apllied
* changed event to on player attached
* removed first time predicted check
* changed cooldown to 0.5 seconds
* made Spell mana change effect not save
* added status efect applied event listner back and moved apply and remove overlay to separete methods
* removed replaced action event
* added fix to let nextupdate catch up to CurTime
* fix: status effect not beeing removed when crit or dead
* fix: Action beeing able to be used while dead
* fix: added prediction check to applied back for double apply and remove bug
---------
Co-authored-by: Red <96445749+TheShuEd@users.noreply.github.com>
* Fix usages of TryIndex()
Most usages of TryIndex() were using it incorrectly. Checking whether prototype IDs specified in prototypes actually existed before using them. This is not appropriate as it's just hiding bugs that should be getting caught by the YAML linter and other tools. (#39115)
This then resulted in TryIndex() getting modified to log errors (94f98073b0), which is incorrect as it causes false-positive errors in proper uses of the API: external data validation. (#39098)
This commit goes through and checks every call site of TryIndex() to see whether they were correct. Most call sites were replaced with the new Resolve(), which is suitable for these "defensive programming" use cases.
Fixes#39115
Breaking change: while doing this I noticed IdCardComponent and related systems were erroneously using ProtoId<AccessLevelPrototype> for job prototypes. This has been corrected.
* fix tests
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* alert cleanup and API
* I expect update loops to be at the top.
* Address review
* Address review x 2
* Merg my PR
* Fix
* Update Content.Shared/Alert/AlertsSystem.cs
webedit
Co-authored-by: Perry Fraser <perryprog@users.noreply.github.com>
* FIX THAT TEST FAIL!!!!
* Me when I forget to actually give you alerts
* Hammedborgar
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
Co-authored-by: Perry Fraser <perryprog@users.noreply.github.com>
* The only commit that matters
* I had to stop playing with my cat to push this change
* Yaml removal
* Proper drunk status effect and remove shitcode
* Review changes
* whoops
* Whoops x2
* Update master fix merge conflicts
* Fix merge conflicts
* Dunk Component kill
* MORE RELAYS
* Holy fucking breaking changes
* Ough
* 46 file diff
* Fix bad commits
* Erm what the test fail?
* Fix those last two
* Merge conflicts
* Me when I fix the merge conflicts
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* feat: add a component for rejuvenateable effects
* feat: let god mode'd entities get buffs
* fix: handle old status effect system
Didn't realize BeforeStatusEffectAddedEvent was called by both systems,
oops.
* refactor: rename to RejuvenateRemovedStatusEffect
* fix: make forced sleeping a debuff again
Missed in rebase.
* refactor: make BeforeStatusEffectAdded two events
* spectra
* documentation
* added into liquid anomaly
* Update TemporaryStealthComponent.cs
* Update TemporaryStealthComponent.cs
* integrated
* new system
* mark old status effect system as obsolete
* ForcedSleeping new status effect
* work with reagents
* networking???
* Revert "integrated"
This reverts commit bca02b82bae18ae131af593d7eb86e6de2745157.
* Revert "Update TemporaryStealthComponent.cs"
This reverts commit 4a5be8c4b704a0d1ff9544b2e245d8b2701ec580.
* Revert "Update TemporaryStealthComponent.cs"
This reverts commit a4875bcb41347638854bd723d96a51c3e6d38034.
* Revert "added into liquid anomaly"
This reverts commit df5086b14bb35f1467158a36807c0f2163a16d99.
* Revert "documentation"
This reverts commit 3629b9466758cbdfa4dd5e67ece122fa2f181138.
* Revert "spectra"
This reverts commit 2d03d88c16d16ad6831c19a7921b84600daeb284.
* drowsiness status effect remove
* reagents work
* polish, remove test changes
* first Fildrance review part
* Update misc.yml
* more fildrance review
* final part
* fix trailing spaces
* sleeping status effect
* drowsiness status effect
* Create ModifyStatusEffect.cs
* some tweak
* Yay!!! Manual networking
* minor nitpick
* oopsie
* refactor: xml-docs, notnullwhen attributes, whitespaces
* fildrance and emo review
* refactor: simplify check in SharedStatusEffectsSystem by using pattern matching, TryEffectsWithComp now returns set of Entity<T, StatusEffectComponent>
---------
Co-authored-by: pa.pecherskij <pa.pecherskij@interfax.ru>
