* Fix usages of TryIndex()
Most usages of TryIndex() were using it incorrectly. Checking whether prototype IDs specified in prototypes actually existed before using them. This is not appropriate as it's just hiding bugs that should be getting caught by the YAML linter and other tools. (#39115)
This then resulted in TryIndex() getting modified to log errors (94f98073b0), which is incorrect as it causes false-positive errors in proper uses of the API: external data validation. (#39098)
This commit goes through and checks every call site of TryIndex() to see whether they were correct. Most call sites were replaced with the new Resolve(), which is suitable for these "defensive programming" use cases.
Fixes#39115
Breaking change: while doing this I noticed IdCardComponent and related systems were erroneously using ProtoId<AccessLevelPrototype> for job prototypes. This has been corrected.
* fix tests
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
This additionally moves the hard-coded check for HandsComp that
previously did this, and moves it into an event which now both
HandsSystem and MechSystem subscribe to.
* fixes item insertion bug
fixes bug where items with complex shapes would fail to insert if the item's StoredRotation wasn't a right angle
* independence from StoredRotation
* Initial:
Create Devour componentry, preliminary identity storage and the systems
for Devouring
* I have genuinely no idea what i'm doing
- added the radial menu, it has nothing in it.
- trying to get it to populate. the event under the event is broken,
i don't know why, but apparently it's not typed right
- Added a placeholder transform
- oh also fixed up some devour stuff and moved some things around.
* Holey moley, Transform, better devour, oh my!
- Move DnaComponent into Shared because we need it for the DNA cloning
- Make Transform MOSTLY work on the LAST identity devoured.
- Fix some issues on devour that involved prediction, canceling and
Damage exeucting (Thanks Plykiya for pointing out AttemptFrequency!)
* Proper tail stealing and Damage modifier attempt
Add check to add a wagging component on the Changeling if the victim's
species Prototype had one.
attempt to add the Damage mitigation check
* MAJOR CLEANUP AND FIXES AUGH 3 DAYS!!!
- Nullspaced a clone of a victim
- fix audio using server virtualized Pvs (i hate this)
- fix the mispredicted doafters
- Clean up a wholelotta code
- utilize clone systems to clone appearances
- Move CloneAppearance from server to shared So we can actually access
it
* Examine stuff, more cleanup, Jumpsuit ripping
- make rotting prevent the action
- Add ripping of clothing (guh why is it also server)
- add some System stuff for pushing husked corpse inspection
- clean up more badcode
* Doing things properly, UI sorta kinda works.
- Utilize Relayed events for Devour checking
- Get a UI that partially works, Says the name of identities, doesn't
show their looks
- Make use of the New Dynamic BUI assignment
- commit the sin of no client prediction cause nullspace entities aren't
networked
* Got an entity for the Frontend transform
Issue with the looks
* Stick a camera into a fake mobs forehead
- Get the UI to see the net entity in pause space by using a
ViewSubscriber to get the Pvs from the initially stored identity entity
- Remove all the other parts used to try to get this to work before hand
* Raaaaadiallllllls also fix protection coefficents
- Change FancyWindow to Radial
- Fix Issue where coeffeient checking was the wrong way round
* absolutely massive cleanup, no more camera in mobs
- cleaned up event variables that are not needed
- Removed the use of a Pause space and go back to Nullspace usage
- use a PvsOverride rather than ViewSharing
- Remove old commented out code and Lots of unused code
* Fix "Ui elements" dying on the screen
- some minor cleanup
- don't start the entities that get cloned
* ftl, cleanup, and fixing missing transform details
- add replace functionality to TypingIndicatorSystem and
BodyEmotesSystem
- add placeholder sounds and functions to TransformBodyEmotes
- add extra Pvs handling for later use
- attributions for the funny straw sound
- Sound collections for all of the sounds
- various cleanups
* Some extra cleanup
* Fix some false assumptions about TypingIndicator
- Bubbles now transfer on spawned humans rather than used humans
- Clean up YET MORE CODE
- make it so you can't eat yourself
* Oooprs, forgot to add a Husked Corpse Loc
* Missing period in the husked corpse loc
* bad devour windup placeholder
* Husking and WIP Lungs
- Husking now will be prevented from Revival fully and will change
the appearance of players
* Add finalized Sprites for actions and final meta
- add devour on and off sprites
- add transform action sprite
- Add Armblade sprite for future use
- Credit obscenelytinyshark for the sprites <3
* Remove ling lungs, Entity<> everything
- Remove the ling lungs stuff for now... body system is overly
complicated, makes my head hurt
- Switch every method to use Entity<> from Uid, Comp format
* cleanup, admin logging, WIP Roles
* Admin verb, Roundstart, gamerule stuff
- add a Admin verb to make Changelingification easy!
- Add game rule stuff for admin verb and to tell the hapless
goober how to be a changeling... sorta
- clean up parts to make VV easy... USE THE VERB!!
* Armor Coefficent Check
- Remove bespoke changeling armor check and replace it
with a generic armor coefficient query.
* move to UnrevivableComponent instead of husked
- Move UnrevivableComponent to shared
- add Analyzable and ReasonMessage to UnrevivableComponent
to give granular control of the message and whether or not it shows up
in the analyzer
- remove the check for HuskedComponent in DefibrillatorSystem
* aaaaaaa CopyComp
- Some cleanup
- make Vocal system shared
- make VocalSystem Not make more Actions than it needs
- Use some code from ChameleonProjector so we can copy components
- partially ungod method the Transform system
* Cleanup, Moving more things to CopyComp
- TransformBodyEmotes now uses CopyComp (it's a server component so i
need to tell the server to deal with it
- TypingIndicatorComponent also now uses CopyComp
- cleaned up old, now unused "replace" methods in favor of CopyComp
- BodyEmotesSystem now has a publically accessable LoadSounds to deal
with the same problem Screaming had
* WIP
* Devour Windup noise, ForensicsSystem cleanup
* Revert VocalSystem Changes
- Reverted Moving VocalSystem to shared, copy comp acomplishes it
- added component.ScreamActionEntity = null; for copy comp
* cleanup unneeded comments
* revert an accidental line removal
* Remove duplicate SharedHumanoidAppearanceSystem
* Cleanup Typo's and import Forensics components for Dna
* Some more forensics calls
* cleanup use CopyComp for now until CopyComps
* CR cleanup
* Undo some SharedHumanoidAppearanceSystem changes
* Confound these spaces
* Some Copycomp stuff and fixing some PVS override
* use the proper TryCopyComps that are merged
* Change TransformMenu with RadialWithSector
* All sounds done, Fix lack of typing indicator issue
* Updated attributions to include used sound authors
* some ftl typos and mind_role text issue
* DNA, Screaming, appearance, grammar, wagging
- reduced all of the above using ApplyComponentChanges
- Issue still remains with bodyEmotes sticking around in the UI
* Fix UI stuff, partials, entprotoid, good practices
- bunch of partials added
- UI now has a predicted message
- EntProtoID in the admin verb
- RipClothing now uses Entity<ButcherableComponent>
- husking is now optional (off by default) for testing/till we have
hivemind/when we figure out what were doing with devour
- remove TransformGrammarSet
* More CR stuff and documentation
- Make TargetIsProtected less of a meme, with a prototype
set of DamageTypes to check
- Documenation everywhere
- Move DevourEvents into its own file
* Predicted sounds and fix the comp clone list
- Made all start and stop sounds shared
- Split out the rest of the events and UI stuff into subfiles
- Fixed some Clone comp list issues where comments had -'s causing them
to be read incorrectly
* Damage cap check, Identity Shutdown cleanup, cleanup
* Sound stuff (but actually this time)
* Missed documentation
* Missed Documentation and a EntProtoId
* Remove unused dependency
* Remove a nullcheck
* Some dummy minplayers
* CR - Husked now uses a rem/ensure
* Update Actions in the Prototype
* Fixup mindswap handover
- cleanup and handover PVS on mindswap
* Fixup Missing meta from accidental "Take-theirs"
* Add the Armblade to the roundstart-role
* Cleanup, CR (everything but the UI and renames)
* missed a spot
* missed some more whitespace
* Renames
* Primary constructor and a space in these trying times
* User interface stuff for Slime transformation
* popup prediction
* Ling devour no longer makes duplicate identities
- added a key to identities to the original victim
- Add some extra clone settings
* add guard statements to OnClones
* SentOnlyToOwner additions
* fix for sound stoppage error
* Move Organ deleter into soon to be atomized husk
* clone event inventory
* mono sounds
* lower sound volume
* Fix networked sound warning
* Clone comps thing
* review
* attributions
* Fix clobbered changes
* I'm gonna weh out
- whole bunch of CR changes
* fix some very buggy git
* okay its fixed
* address most review points
* fix inventory
* we hate entityuids
* fix test and more cleanup
* move this
* fix more stuff
* fix validation and rootable
* Remove Quickswitch due to some UI quirks
* oops left out some better explanation
* remove dangling LastConsumed component fields
* fix test fail
* try this
* cleanup cloning subscriptions, add movement speed modifier
* fix slime storage
* fix cloning setting inheritance
* Add session information to transform admin logs
* slay the integration test hydra
* dwarf size
* more volume tweaks
* comments
* improve comments and unpredict deletion due to errors when shutting down the server
* fix displancement cloning
---------
Co-authored-by: ScarKy0 <scarky0@onet.eu>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Shelve
* 22 file diff
* What if it was just better
* Hold that thought
* Near final Commit, then YAML hell
* 95% done with cs
* Working Commit
* Final Commit (Before reviews tear it apart and kill me)
* Add a really stupid comment.
* KILL
* EXPLODE TEST FAILS WITH MY MIND
* I hate it here
* TACTICAL NUCLEAR STRIKE
* Wait what the fuck was I doing?
* Comments
* Me when I'm stupid
* Food doesn't need solutions
* API improvements with some API weirdness
* Move non-API out of API
* Better comment
* Fixes and spelling mistakes
* Final fixes
* Final fixes for real...
* Kill food and drink localization files because I hate them.
* Water droplet fix
* Utensil fixes
* Fix verb priority (It should've been 2)
* A few minor localization fixes
* merge conflict and stuff
* MERGE CONFLICT NUCLEAR WAR!!!
* Cleanup
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* checkpoint
* pt 2
* pt... i forgot
* pt 4
* patch
* More test fixes
* optimization!!!
* the REAL hand system
* fix RetractableItemActionSystem.cs oversight
* the review
* test
* remove test usage of body prototype
* Update Content.IntegrationTests/Tests/Interaction/InteractionTest.cs
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
* hellcode
* hellcode 2
* Minor cleanup
* test
* Chasing the last of the bugs
* changes
---------
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
* Work for a madman
* God, that's a lot of hardcoding
* Fixed belt2 smartequip and cleaned up
* Continued clean up
* No scope creep!
* Replaced belt1 for upstream default belt
* Moved CP14OpenSkillMenu to CP14ContentContexts
* Changed naming of belt1 textures to just belt
* Updated new belt1 refrences
* I forgot to edit the RSI meta
* fix all BELT1 Texture instance
---------
Co-authored-by: Red <96445749+TheShuEd@users.noreply.github.com>
* Optimise storage a quadrillion times
* How sweaty can we get
* Add fast angle checks
* Fix chunk indices
* Optimise the refresh method
Helps on client a lot as the clientside is suboptimal atm.
* Better name
* wawawewa
* Add single-angle path
* Okay FINE rider
* Predict dumping
- This got soaped really fucking hard.
- Dumping is predicted, this required disposals to be predicte.d
- Disposals required mailing (because it's tightly coupled), and a smidge of other content systems.
- I also had to fix a compnetworkgenerator issue at the same time so it wouldn't mispredict.
* Fix a bunch of stuff
* nasty merge
* Some reviews
* Some more reviews while I stash
* Fix merge
* Fix merge
* Half of review
* Review
* re(h)f
* lizards
* feexes
* feex
* Add smuggler stashes
* Prevent anchor/collision test fail
* Enabled = false
* Oops, missed one
* NYAH!1984
* Split/Rebalance loot pools and fix test fail
* Errg, still with the canCollide thing
* Removed notes, additional balance tweaking, removed some blank lines
* Replace generator IDs
* Adjust briefcase fill
* Node moved
* Use noSpawn
* Goldschlonger
* Adjusts fills for grid-inv
* Replace removed items
* Replace removed items part 2
* Add empty satchel to clothesmate contraband inventory
* Merge master and switch spawning to roundstart event
* Cleaned up and converted to entity spawn tables + Added funny clown satchel
* Adds comp to prevent stacking bags
* Inital cleanup
* More changes
* ff
* Some fixes but yaml needs to be organized and a few bugs remain
* Final fixes
* Cleanup
* good
* One more
* minor tweaks
* Rename
* Combine dupe fields
* address review
* review
* make linter happy
* names, contraband status
* uplink
* small bugfix
---------
Co-authored-by: Jeff <velcroboy333@hotmail.com>
Co-authored-by: beck-thompson <beck314159@hotmail.com>
Co-authored-by: Milon <milonpl.git@proton.me>
Co-authored-by: ScarKy0 <scarky0@onet.eu>
* Add new implants to deimplant list (#35563)
Initial commit
* Doxarubixadone Description Fix (#35568)
Changed medicine.ftl for Doxa.
* Reptilians Can Eat Chicken Nuggets (#35569)
Added meat tag to misc.yml for chicken nuggets.
* Automatic changelog update
* Unheck Admin Smites (#35348)
* Fix admin verb names
Fixed admin verb names.
* Add antag verb names
* Adjust antag verb icons
* Amber Station - A Couple Changes (#35548)
* [ADMIN] Minor Refactor AdminNameOverlay (#35520)
* refactor(src): Minor refactor of Draw in "AdminNameOverlay. And new info about playtime player
* fix(src): Add configure classic admin owerlay
* fix
* tweak(src): Use _antagLabelClassic and tweak style
* tweak(src): Add config display overlay for startingJob and playTime
* tweak(src): Vector2 is replaced by var
* tweak(src): return to the end of the list
* Automatic changelog update
* Wizard PDA (#35572)
* wizard PDA
* colour change to brown
* Automatic changelog update
* Increase line spacing of the admin overlay (#35591)
line spacing
* make slime hair less transparent (#35158)
* blabl blump or something
* +0.3
* blimpuf
* Automatic changelog update
* Fix being able to write on/stamp/fax paper scrap (#35596)
* init
* item
* requested changes
* Apply suggestions from code review
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Automatic changelog update
* Changed Pride to Hubris in ion_storm.yml (#35602)
Update ion_storm.yml
* Sentry turrets - Part 3: Turret AI (#35058)
* Initial commit
* Updated Access/command.yml
* Fix for Access/AccessLevelPrototype.cs
* Added silicon access levels to admin items
* Included self-recharging battery changes
* Revert "Included self-recharging battery changes"
* Addressed reviewers comments
* Additional reviewer comments
* DetGadget Hat Revitalization (#35438)
* DetGadget Hat
* uh... half-assed item description
* Reduce hat range to one tile, you have to stand on someone to steal their hat items
* Fix Integration Errors
* Only the wearer can access voice commands
* init work - handscomp is unable to be pulled
* second bit of progress
* basic working implementation
* nuke storageslots and add adminlogging
* disallow trolling nukies or hiding objective items
* remove unnecessary tags additions
* finish nuking unused tags
* death to yamllinter
* int tests be damned
* milon is a furry
* address review
* upd desc
* address reviews part 2
* address more reviews
* remove unused refs
* fix order of dependencies
* add ShowVerb to SharedStorageSystem.cs
This will allow or disallow showing the "Open Storage" verb if defined on the component.
* orks is a nerd
* add proper locale, fix adminlogging
* orks is a nerd 2
---------
Co-authored-by: Coenx-flex <coengmurray@gmail.com>
* Automatic changelog update
* Fingerprint Reader System (#35600)
* init
* public api
* stuff
* weh
* Remove cellular resistance for slimes (#35583)
* Remove cellular resistance for slimes
* Update guidebook
* Automatic changelog update
* Give the station map inhand sprites (#35605)
map has inhands
* Reagent guidebook reactions UI dividers (#35608)
* Update GuideReagentReaction.xaml
* Update Content.Client/Guidebook/Controls/GuideReagentReaction.xaml
Co-authored-by: Thomas <87614336+Aeshus@users.noreply.github.com>
* Update Content.Client/Guidebook/Controls/GuideReagentReaction.xaml
Co-authored-by: Thomas <87614336+Aeshus@users.noreply.github.com>
---------
Co-authored-by: Thomas <87614336+Aeshus@users.noreply.github.com>
* fix cluwne pda pen slot (#35611)
Co-authored-by: deltanedas <@deltanedas:kde.org>
* Revert "Make radioactive material radioactive" (#35330)
* Automatic changelog update
* Predict vending machine UI (#33412)
* Automatic changelog update
* #32209 changelog (#35619)
Since it was merged into staging no changelog was made, but we should at least have it for next release. (And vulture)
* Automatic changelog update
* Cloning Refactor and bugfixes (#35555)
* cloning refactor
* cleanup and fixes
* don't pick from 0
* give dwarves the correct species
* fix dna and bloodstream reagent data cloning
* don't copy helmets
* be less redundant
* Automatic changelog update
* centcomm update (#35627)
* Better Insectoid Glasses (#31812)
Sprites and file changes
Adds the variants for arachnid and moth glasses, adds the code for those in the meta.json files, and adds the speciesID tag in both arachnid and moth prototype files.
* Automatic changelog update
* Add GetBaseName method to NameModifierSystem (#35633)
* Add GetBaseName method to NameModifierSystem
* Use Name
* Save Space Station 14 from the Toilet Gibber Forever (#35587)
* The evil is defeated
* Tag body bags
* uwu, cwush me cwusher-chan
* absolute 18+ sloggery
* botos binted? 👽
* Automatic changelog update
* Changed Damage Overlay to check Burn Damage (#34535)
* updated BruteLevel to be PainLevel with burn damage checks in DamageOverlayUiController.cs
* dehardcoded pain level by adding damage groups to paindamagegroups to affect
* re-added the name for painDamageGroups
* fixed overlay default and added minimum limit to component check first
* renamed to PainDamageGroups and removed obsolete tag
* Automatic changelog update
* Wizard's Magical Pen (#35623)
* wizard pen
* description change
* Automatic changelog update
* Added decelerator percentage drain (#35643)
* Added variable PercentageDrain to SinguloFoodComponent
* Set percentageDrain to 0.03 (3%) for anti particles
* Added percentageDrain logic in public OnConsumed
* Simplify SinguloFoodComponent and set percentageDrain to negative
* EnergyFactor now applies to positive values too
* Better commenting on EnergyFactor
* Update Content.Server/Singularity/Components/SinguloFoodComponent.cs
* Documentation of EnergyFactor
* Fixing spelling mistake
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Automatic changelog update
* Made butter require less milk (#35650)
made butter take less milk
* Automatic changelog update
* Delete SolutionContainerVisualsComponent.InitialName (#35654)
* Fix name of cotton dough rope (#35657)
changed in-game name of cotton dough rope to differentiate from normal dough rope
* CVar - Toggle display of round-end greentext (#35651)
* hide greentext if cvar false
* change IFs around a lil
* reviews
* Open State for cowtools (#35666)
Open State
* Make implants unshielded (#35667)
* Add undergarments & "Censor Nudity" toggle to options (#33185)
* Initial commit
* Attribution
* Review changes
* Added comment for upstream
* Automatic changelog update
* centcomm update (#35674)
* More scars! (#35644)
* :3
* whitespace, stomach scar
* Automatic changelog update
* Lathe menu UI displays a count of available recipes (#35570)
* commit
* jumped the gun
* changes
* Players with unknown playtimes now are tagged as new players, take 2 (#35648)
* your commit? our commit.
* skreee
* show joined players before lobby players; comments
* comments
* playerinfo retains playtime data after disconnect
* new connection status symbols
* Automatic changelog update
* Add firelocks and locked external airlocks to ATS (#35516)
* Add firelocks and locked airlocks to ATS
* Add fire alarms
* Elkridge Tesla and TEG Improvements + Other stuff (#35684)
* better tesla, better TEG, better sci maints, chef gets chef closet
* added storage room for tesla parts, added captain bathroom, changed vault so nuke can be armed
* ran fixgridatmos and added some vacuum markers
* unflatpacked containment shit
* Cargo Mail System (#35429)
* shitcode init
* biocoding, SpawnTableOnUse, Moving shit to shared
* server :(
* fixes
* ok works
* Discard changes to Content.Shared/Interaction/Events/GettingUsedAttemptEvent.cs
* Discard changes to Content.Shared/Forensics/Components/FingerprintMaskComponent.cs
* Discard changes to Content.Shared/Forensics/Components/FingerprintComponent.cs
* Discard changes to Content.Server/Forensics/Systems/ForensicsSystem.cs
* Discard changes to Content.Server/StationRecords/Systems/StationRecordsSystem.cs
* Discard changes to Content.Server/Storage/EntitySystems/SpawnItemsOnUseSystem.cs
* Discard changes to Content.Shared/Interaction/Events/GettingUsedAttemptEvent.cs
* big stuff
* preperation
* temperory spawning thing for testing
* Update CargoDeliveryDataComponent.cs
* kinda proper spawning idk god save me
* cleanup (kinda)
* preparation 2.0
* stuff i think
* entity table work
* renames
* spawn ratio based on players
* comment
* letter tables
* more spam
* package tables
* comment
* biocodedn't
* builds correctly
* cleaning
* Update deliveries_tables.yml
* labels
* package sprites
* mail teleporter
* revert testing value
* fix test
* fix other test
* i love tests
* mail teleporter enabled by default
* random cooldowns
* fixtures
* Discard changes to Content.Shared/FingerprintReader/FingerprintReaderComponent.cs
* Discard changes to Content.Shared/FingerprintReader/FingerprintReaderSystem.cs
* Discard changes to Content.Shared/Interaction/Events/GettingUsedAttemptEvent.cs
* Discard changes to Resources/Locale/en-US/fingerprint-reader/fingerprint-reader.ftl
* clean
* fuck paper scrap
* oops
* fuck SpawnTableOnUse
* mail teleporter board in QM locker + addressed review
* oops
* clean
* sound on delivery spawn
* address review
* partial review address
* partial review addressing
* addressing partial review
* pratarial revivew address
* misprediction hell
* stuff
* more stuff
* unrelated
* TODO
* link
* partial review
* DirtyField
---------
Co-authored-by: Milon <milonpl.git@proton.me>
* Automatic changelog update
* Add AssertMultiple to ContrabandTest (#35662)
* add AssertMultiple to ContrabandTest
* do the same for magazine visuals test
* :trollface:
---------
Co-authored-by: deltanedas <@deltanedas:kde.org>
* add forceghost admin command (#35518)
* add forceghost admin command
* sweep linq under the rug
* braces
* ûse LocalizedEntityCommands
* Automatic changelog update
* Text related keybinds can now be changed in Controls (#35630)
* Add ability to rebind text related keybinds
* fix placement of locales
* Automatic changelog update
* Update b2dynamictree (#30630)
* Update submodule to 248.0.0 (#35720)
* Add sun shadows (planet lighting stage 2) (#35145)
* Implements a Dynamic Lighting System on maps.
* Edit: the night should be a little bit brighter and blue now.
* Major edit: everything must be done on the client side now, with certain datafield replicated.
Changes were outlined in the salvage to accommodate the new lighting system.
* Edit: The offset is now serverside, this makes the time accurate in all situations.
* Removing ununsed import
* Minor tweaks
* Tweak in time precision
* Minor tweak + Unused import removed
* Edit: apparently RealTime is better for what I'm looking for
* Fix: Now the time is calculated correctly.
* Minor tweaks
* Adds condition for when the light should be updated
* Add planet lighting
* she
* close-ish
* c
* bittersweat
* Fixes
* Revert "Merge branch '22719' into 2024-09-29-planet-lighting"
This reverts commit 9f2785bb16aee47d794aa3eed8ae15004f97fc35, reversing
changes made to 19649c07a5fb625423e08fc18d91c9cb101daa86.
* Europa and day-night
* weh
* rooves working
* Clean
* Remove Europa
* Fixes
* fix
* Update
* Fix caves
* Update for engine
* Add sun shadows (planet lighting v2)
For now mostly targeting walls and having the shadows change over time. Got the basic proof-of-concept working just needs a hell of a lot of polish.
* Documentation
* a
* Fixes
* Move blur to an overlay
* Slughands
* Fixes
* Apply RoofOverlay per-grid not per-map
* Fix light render scales
* sangas
* Juice it a bit
* Better angle
* Fixes
* Add color support
* Rounding bandaid
* Wehs
* Better
* Remember I forgot to do this when writing docs
---------
Co-authored-by: DoutorWhite <thedoctorwhite@gmail.com>
* Automatic changelog update
* Omega Mail Teleporter (#35705)
Mail!
* Packed Mail Teleporter (#35706)
Mail!
* Box Mail Teleporter (#35707)
Mail!
* Oasis Mail Teleporter (#35708)
Mail!
* Meta Mail Teleporter (#35709)
Mail!
* Marathon Mail Teleporter (#35710)
Mail!
* Fland Mail Teleporter (#35711)
Mail!
* Plasma fixes 4 (#35716)
Fixes 15
Co-authored-by: jbox1 <40789662+jbox144@users.noreply.github.com>
* Aroace pride pin, scarf, and cloak (#35718)
cloak, pin, and scarf added yayyyy
* Automatic changelog update
* [Part of #32893] Localize silicon dataset names (#33352)
* Localize ai names
* Apply requested changes
* Localize autoborg
* Localize borg names
* Localize atv names
* Correct prototypes ids to follow naming conventions
* Remove AI localization (Moved to another PR)
* Weh
* [Part of #32893] Localize arachnid dataset names (#33353)
* Localize arachnid dataset names
* Correct prototype ids to follow naming conventions
* Combine arachnid_first.yml and arachnid_last.yml
* Upstream names
* [Part of #32893] Localize summonable creatures dataset names (#33392)
* Localize clown names
* Localize golem names
* Localize hologram names
* Correct prototype ids to follow naming conventions
* Update Resources/Locale/en-US/datasets/names/golem.ftl
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* [Part of #32893] Localize antagonists dataset names (#33393)
* Localize fake human names
* Localize ninja names
* Localize operation names
* Localize regalrat names
* Localize revenant names
* Localize syndicate names
* Localize wizard names
* Correct prototype ids to follow naming conventions
* Combine fake_human_first.yml and fake_human_last.yml
* Move contents of ninja_title.yml into ninja.yml
* Combine Operation_prefix.yml and Operation_suffix.yml
* Combine wizard_first.yml and wizard_last.yml
* Upstream names
* fix wizard
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* [Part of #32893] Localize humanoid species dataset names (#33395)
* Localize diona names
* Localize moth names
* Localize mushman names
* Localize reptilian names
* Localize skeleton names
* Upstream diona names
* names-moth-male/female-first-dataset -> names-moth-first-male/female-dataset
* Correct prototype ids to follow naming conventions
* NamesSkeletonFirst -> NamesSkeleton
* Combine moth_first_female.yml, moth_first_male.yml and moth_last.yml
* Forgot about skeleton prototype
* Upstream names
* Update Resources/Locale/en-US/datasets/names/diona_last.ftl
* Update Resources/Locale/en-US/datasets/names/diona_last.ftl
* keep first name for skeleton
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* [Part of #32893] Localize vox dataset names (#33396)
* Localize vox names
* Correct prototype id to follow naming conventions
* Upstream names
* [Part of #32893] Localize first & last dataset names (#33401)
* Localize first names
* Localize last names
* Correct prototype ids to follow naming conventions
* Combine first.yml and last.yml into base.yml
* Forgot about = in last
* [Part of #32893] Localize first male & female dataset names (#33402)
* Localize first_name
* Localize first_female
* names-male/female-first-dataset -> names-first-male/female-dataset
* Correct prototype ids to follow naming conventions
* Combine first_male.yml and first_female.yml into base_gendered.yml
* [Part of #32893] Localize misc dataset names (#33404)
* Localize cargo_shuttle names
* Localize death_commando names
* Localize fortunes
* Localize military names
* Localize rollie names
* fortunes.ftl -> cookie_fortune.ftl
* Correct prototype ids to follow naming conventions
* Localize all dataset names (#32893)
* Use `LocalizedDatasetPrototype` instead of `DatasetPrototype` in `RoleLoadoutPrototype`
* Localize ai names
* Replace to `LocalizedDatasetPrototype` in `NamingSystem`
* Localize arachnid first and last names
* Localize atv names
* Localize autoborg names
* Forgot to change type to localizedDataset
* Localize borer names
* Localize borg names
* Localize cargo shuttle names
* Localize clown names
* Localize death_commando names
* Localize diona names
* Localize fake_human names
* Localize first and last names
* Localize first male and female names
* Localize fortunes descriptions
* Forgot about equal sign
* Localize golem names
* Localize hologram names
* Localize military names
* Localize moth first male and female names
* Localize moth last names
* Fix autoborg name error
* Localize mushman first and last names
* Localize ninja names
* Localize operation names
* Localize regalrat names
* Fix mushman_first
* Forgot about `Loc.GetString`
* Move comments into comment section & fix names
* Localize reptilian male and female names
* Localize revenant names
* Fix locale word order in operation
* Localize rollie (btw it was never used and was added as "for the futuгe" long time ago)
* Localize skeleton_first names
* Localize syndicate names
* Localize vox names
* Localize wizard first and last names
* `{owner}-name-dataset` -> `names-{owner}-dataset`
* Change `DatasetPrototype` to `LocalizedDatasetPrototype` and make sure it works properly
GetFTLName is no more the static method, we need it to be able to use `Loc.GetString`
* I hate those mothname comments
* Combine name datasets prototypes
* Move every ftl from` /en-US/names` to ` /en-US/datasets/names`
* Remove ftl files
* Get every dataset yml back
* Remove changes for planets. Move it in another PR
* Revert these changes (Moved to another PR)
* How
* Apply suggested changes
* Fix integration tests (#35727)
* test
* fix names
* fix more
* Initial delivery balance changes (#35728)
* init
* small balance
* guess not
* Update Content.Server/Delivery/CargoDeliveryDataComponent.cs
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Fixed delivery popups (#35724)
* :)
* cool stuff
* Remove a bonus Loc.GetString (#35731)
oops
* Bagel Engineering Improvements (#35717)
* woe, better engineering be upon ye
* im going to lose it
* radical plan
* oopsie
* Revert "oopsie"
This reverts commit 45ab057f55b46acd795e58257c3cc5967e5cb946.
* Revert "radical plan"
This reverts commit 57b1ae081725a47aef3ae03111cecbc91b4f47a8.
* Revert "im going to lose it"
This reverts commit e7b4afaf5d9a10a42e89831ffc9294d3b9bd96d4.
* Revert "woe, better engineering be upon ye"
This reverts commit 471dc3716b58a39631aa8bee00de79e981391d63.
* complete revamp
* revision
* oops 2 electric boogaloo
* another one
* every time i push to fix a minor mistake i found in walking around i get closer to my limit
* Update Credits (#35733)
Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com>
* Loop mail teleporter (#35729)
* latejoin
* youve got mail
* Core mail update (#35719)
* core mail update
* empty
* derotate core (#35740)
Update default.yml
* Elkridge Mail Update (#35738)
add mail teleporter and mailing unit system
* Automatic changelog update
* Plasma Mail Teleporter (#35741)
Mail!
* Convex Mail Teleporter (#35742)
Mail!
* Remove unneeded Loc.GetString (#35739)
* Steal the mail thieving objective (#35746)
* mail theft
* networked
* Automatic changelog update
* fix UpdateBankAccount (#35749)
* trolled
* fun
* fuck me
* Slightly better letter loot table (#35748)
* init
* review
---------
Co-authored-by: Milon <milonpl.git@proton.me>
* Python Suit Storage Visual (#35593)
* Python-SUITSTORAGE-Visuals
Signed-off-by: Prole <172158352+Prole0@users.noreply.github.com>
* REVised Sprite
Signed-off-by: Prole <172158352+Prole0@users.noreply.github.com>
* Copyright
Signed-off-by: Prole <172158352+Prole0@users.noreply.github.com>
* Update Resources/Textures/Objects/Weapons/Guns/Revolvers/python.rsi/meta.json
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
---------
Signed-off-by: Prole <172158352+Prole0@users.noreply.github.com>
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* fix nukeops commander name (#35753)
* bagel update (#35754)
* Predict some power PowerReceiver stuff (#33834)
* Predict some power PowerReceiver stuff
Need it for some atmos device prediction.
* Also this
* Localize traitor codeverbs datasets (#35737)
* Localize verbs dataset
* Localize adjectives dataset
* Localize corporations dataset
* Update TraitorRuleSystem to use LocalizedDatasetPrototype instead of DatasetPrototype
* Fix sun shadows in ANGLE (#35757)
I think I fat-fingered a ctrl-Z on this at some point but the intermediate blur is necessary.
* Automatic changelog update
* Tweak sun shadow rotations (#35758)
Won't use the entity's rotation for the matrix, I just forgot to do this. Means shadows will always point in the same direction and the points will correctly adjust as the entity rotates.
* Automatic changelog update
* Fix Ahelp window playerlist resize (#35747)
reorganize bwoink window layout
* Automatic changelog update
* Ensure speech bubble cap is always respected (#32223)
Ensure speech bubble cap is respected, even when messages are sent very fast
* Cleanup: Fix ``PaperWriteEvent`` in ``PaperSystem`` (#35763)
* Cleanup + fix
* Revert
* Cleanup: Add missing locale ``cmd-planet-map-prototype`` (#35766)
Cleanup
* Added New Cocktails and new fill level sprites to existing drinks. (#33570)
* Added New Cocktails and new fill level sprites to existing drinks
* Updated copyright info and fixed recipies for Caipirinha/Mojito.
---------
Co-authored-by: RedBookcase <Usualmoves@gmail.com>
* Automatic changelog update
* Performer's Wig (#35764)
* miku wig
* fix to correct json convention
Co-authored-by: Winkarst <74284083+Winkarst-cpu@users.noreply.github.com>
---------
Co-authored-by: Winkarst <74284083+Winkarst-cpu@users.noreply.github.com>
* Automatic changelog update
* Merge showsubfloorforever into showsubfloor (#33682)
* convex fix
* Removable mindshields and revolutionary tweaks. (#35769)
* I fucking hate revs
* Update preset-revolutionary.ftl
* fixy fix
* Automatic changelog update
* Mail Resprite (#35776)
* init commit
* init commit
* delete those
* added github to copyright info
* Fix Chameleon PDAs renaming the user in station records (#35782)
* Automatic changelog update
* Restore the order of admin overlay elements (#35783)
admin overlay order fix
* Automatic changelog update
* Fixes and refactoring to discord changelog script (#33859)
* Fixes and refactoring to discord changelog script
Upstreamed from https://github.com/impstation/imp-station-14/pull/1023
* Add some prints back in
* Update to borg ion storms (#35751)
* Updates ion storms for borgs.
* Remove additional ion laws into future PR
* Automatic changelog update
* TriggerSystem improvements (#35762)
* desynchronizer real
* yaml stuff from slarti branch
* C# stuff
* oops
* fix triggers
* atomize PR
---------
Co-authored-by: Flareguy <woaj9999@outlook.com>
* Roleban command error handling (#35784)
roleban command jobid fail handling
* Localize news dataset (#35774)
* Localize news dataset
* Remove the `"`
* Localize rat king commands datasets (#35780)
* Added mail room
* Update submodule to 248.0.2 (#35787)
* Update Space Law to reflect Implant changes (#35701)
* Change implanter Space Law
* Add clarification regarding unidentified implanter vs. unidentified implant sentensing
* Add support for antag-before-job selection (#35789)
* Add support for antag-before-job selection
* Include logging
* forensics cleanup (#35795)
* polymorph popup fixes (#35796)
polymorph fixes
* fix more syndicate names (#35788)
* New Feature: Warden job rolls before security officer/cadet/detective (#35313)
Commit
* Automatic changelog update
* Fix anomaly doublelogging (#34297)
cull doublelogging
* Add wallmount N2 closets, Revived (#34042)
* Add standard, wallmount and improvised N2 closets, Revived
* remove improvised locker
* Parent>ID
* Undo sprite replacement
* Update meta.json
---------
Co-authored-by: Velcroboy <velcroboy333@hotmail.com>
Co-authored-by: Milon <milonpl.git@proton.me>
* Cryo and grinder cleanup (#34842)
* cryopod and grinder cleanup
* lower case name
* 4 spaces
* prototype clean
* looks like there is some kind of test that prevents removing this
* grinder too
* both should be empty
* cleanup
* Add Gold and Coal Rock Anomalies (#34809)
* This commit adds 2 new Rock Anomaly types, Coal and Gold. It also adds Resource Crabs, colored crystals, and lights for both.
* Added crafting recipes for yellow and black light tubes. Somehow I forgot that the first time.
* Sorted tags.yml alphabetically this time instead of not doing that.
* Updated Texture Copyright information
* Attempted to fix Merge Conflict
* Added bulb light variants for both yellow and black crystals.
* Automatic changelog update
* Tools/Devices: In-hand Sprites (#33689)
* Adds in-hand sprites to the barber scissors.
* adds in-hand sprites to the floodlight.
* adds in-hand sprites to the gas analyzer.
* adds in-hand sprites to the gps.
* Update copyright wording, linting
* resprite gps inhand sprites.
* adds in-hand sprites to the mass scanner.
* adds in-hand sprites to the spray_painter.
* resprite in-hand sprites to the mass_scanner.
* fix in-hand sprites to the mass_scanner.
* Resprite mass_scanner in-hand sprites.
* Automatic changelog update
* IconSmooth additional smoothing keys (#35790)
* additionalKeys
* Update lava.yml
* Update Content.Client/IconSmoothing/IconSmoothComponent.cs
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Locks nitrous oxide canisters (#35785)
lock nitrous oxide canisters
* Automatic changelog update
* Cleanup Objective files, add PickSpecificPersonComponent (#35802)
* cleanup objectives
* remove unrelated access restriction
* review
* Adds popup when firing gun while gun has no ammo (#34816)
* Adds popup when firing gun while gun has no ammo
* simplify
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Automatic changelog update
* Add the ability to pet the mail teleporter (#35819)
good mailbox
* Automatic changelog update
* Whitehole/Singularity grenade price adjustments + whitehole grenade fix (#35821)
* prices + adjustments
* teehee
* Automatic changelog update
* Update Lobby Music Attribtions (#35817)
Biggest change is updating the attributions and links for Sunbeamstress' to reflect the changes in their online profile as the previous link is now a dead link.
Updated Comet Haley's link to go directly to Stellardrone's Bandcamp instead of diverting to Free Music Archive
Fixed a double the in the comment for Space Asshole
* Paradox Clone (#35794)
* polymorph fixes
* paradox clone
* forensics cleanup
* bump doors
* 4
* attribution
* polymorphn't
* clean up objectives
* Update Resources/ServerInfo/Guidebook/Antagonist/MinorAntagonists.xml
* review
* add virtual items to blacklist
* allow them to roll sleeper agent
* Automatic changelog update
* Improvements to antag-before-job selection system (#35822)
* Fix the latejoin-antag-deficit bug, add datafield, add logging
* Fix multiple roles being made for single-role defs,
* HOTFIX: Fix paradox clone event (#35858)
fix paradox clone event
* Update CP14TownSendConditionSystem.cs
---------
Signed-off-by: Prole <172158352+Prole0@users.noreply.github.com>
Co-authored-by: SlamBamActionman <83650252+SlamBamActionman@users.noreply.github.com>
Co-authored-by: Smith <182301147+AgentSmithRadio@users.noreply.github.com>
Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com>
Co-authored-by: Pancake <Pangogie@users.noreply.github.com>
Co-authored-by: Southbridge <7013162+southbridge-fur@users.noreply.github.com>
Co-authored-by: Schrödinger <132720404+Schrodinger71@users.noreply.github.com>
Co-authored-by: Velken <8467292+Velken@users.noreply.github.com>
Co-authored-by: Errant <35878406+Errant-4@users.noreply.github.com>
Co-authored-by: LaCumbiaDelCoronavirus <90893484+LaCumbiaDelCoronavirus@users.noreply.github.com>
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
Co-authored-by: FungiFellow <151778459+FungiFellow@users.noreply.github.com>
Co-authored-by: chromiumboy <50505512+chromiumboy@users.noreply.github.com>
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
Co-authored-by: Coenx-flex <coengmurray@gmail.com>
Co-authored-by: hivehum <ketchupfaced@gmail.com>
Co-authored-by: Thomas <87614336+Aeshus@users.noreply.github.com>
Co-authored-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: Myra <vasilis@pikachu.systems>
Co-authored-by: Emisse <99158783+Emisse@users.noreply.github.com>
Co-authored-by: HTML/Crystal <152909599+HTMLSystem@users.noreply.github.com>
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
Co-authored-by: Hannah Giovanna Dawson <karakkaraz@gmail.com>
Co-authored-by: Coolsurf6 <coolsurf24@yahoo.com.au>
Co-authored-by: rokudara-sen <160833839+rokudara-sen@users.noreply.github.com>
Co-authored-by: DuckManZach <144298822+DuckManZach@users.noreply.github.com>
Co-authored-by: MisterImp <101299120+MisterImp@users.noreply.github.com>
Co-authored-by: Killerqu00 <47712032+Killerqu00@users.noreply.github.com>
Co-authored-by: Ps3Moira <113228053+ps3moira@users.noreply.github.com>
Co-authored-by: nikthechampiongr <32041239+nikthechampiongr@users.noreply.github.com>
Co-authored-by: Boaz1111 <149967078+Boaz1111@users.noreply.github.com>
Co-authored-by: āda <ss.adasts@gmail.com>
Co-authored-by: War Pigeon <54217755+minus1over12@users.noreply.github.com>
Co-authored-by: Deerstop <edainturner@gmail.com>
Co-authored-by: Milon <milonpl.git@proton.me>
Co-authored-by: Łukasz Mędrek <lukasz@lukaszm.xyz>
Co-authored-by: DoutorWhite <thedoctorwhite@gmail.com>
Co-authored-by: compilatron <40789662+Compilatron144@users.noreply.github.com>
Co-authored-by: jbox1 <40789662+jbox144@users.noreply.github.com>
Co-authored-by: Momo <Rsnesrud@gmail.com>
Co-authored-by: MilenVolf <63782763+MilenVolf@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: TytosB <54259736+TytosB@users.noreply.github.com>
Co-authored-by: Prole <172158352+Prole0@users.noreply.github.com>
Co-authored-by: Evelyn Gordon <evelyn.gordon20@gmail.com>
Co-authored-by: Winkarst <74284083+Winkarst-cpu@users.noreply.github.com>
Co-authored-by: RedBookcase <crazykid1590@gmail.com>
Co-authored-by: RedBookcase <Usualmoves@gmail.com>
Co-authored-by: SpaceManiac <tad@platymuus.com>
Co-authored-by: Spessmann <156740760+Spessmann@users.noreply.github.com>
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
Co-authored-by: imcb <irismessage@protonmail.com>
Co-authored-by: valquaint <57813693+valquaint@users.noreply.github.com>
Co-authored-by: Flareguy <woaj9999@outlook.com>
Co-authored-by: ninruB <ninrub@tuta.io>
Co-authored-by: Velcroboy <107660393+IamVelcroboy@users.noreply.github.com>
Co-authored-by: Velcroboy <velcroboy333@hotmail.com>
Co-authored-by: Łukasz Lindert <lukasz.lindert@protonmail.com>
Co-authored-by: Firewars763 <35506916+Firewars763@users.noreply.github.com>
Co-authored-by: onesch <118821520+onesch@users.noreply.github.com>
Co-authored-by: K-Dynamic <20566341+K-Dynamic@users.noreply.github.com>
Co-authored-by: Plykiya <58439124+Plykiya@users.noreply.github.com>
Co-authored-by: Crude Oil <124208219+CroilBird@users.noreply.github.com>
Co-authored-by: Lusatia <ultimate_doge@outlook.com>
* DetGadget Hat
* uh... half-assed item description
* Reduce hat range to one tile, you have to stand on someone to steal their hat items
* Fix Integration Errors
* Only the wearer can access voice commands
* init work - handscomp is unable to be pulled
* second bit of progress
* basic working implementation
* nuke storageslots and add adminlogging
* disallow trolling nukies or hiding objective items
* remove unnecessary tags additions
* finish nuking unused tags
* death to yamllinter
* int tests be damned
* milon is a furry
* address review
* upd desc
* address reviews part 2
* address more reviews
* remove unused refs
* fix order of dependencies
* add ShowVerb to SharedStorageSystem.cs
This will allow or disallow showing the "Open Storage" verb if defined on the component.
* orks is a nerd
* add proper locale, fix adminlogging
* orks is a nerd 2
---------
Co-authored-by: Coenx-flex <coengmurray@gmail.com>
