From 672474587bd26e34105267b5efe81aa159f3fa8b Mon Sep 17 00:00:00 2001 From: Kevin Ngo Date: Sat, 13 Oct 2018 17:26:03 -0700 Subject: [PATCH] more linting, lots of undefined vars or unused vars --- src/components/beat-loader.js | 6 +++--- src/components/beat.js | 8 +------- src/components/cursor-mesh.js | 3 --- src/components/materials.js | 4 +++- src/components/menu-controls.js | 1 - src/components/search-thumbnail-atlas.js | 1 - src/components/search.js | 1 + src/components/song-preview.js | 2 +- src/components/song.js | 2 -- src/components/trail.js | 10 +++------- src/lib/soundpool.js | 2 +- src/state/index.js | 6 +++--- 12 files changed, 16 insertions(+), 30 deletions(-) diff --git a/src/components/beat-loader.js b/src/components/beat-loader.js index 8fc709b..432081e 100644 --- a/src/components/beat-loader.js +++ b/src/components/beat-loader.js @@ -161,7 +161,6 @@ AFRAME.registerComponent('beat-loader', { return function (noteInfo) { var beatEl; var color; - var orientation; var type = noteInfo._cutDirection === 8 ? 'dot' : 'arrow'; color = noteInfo._type === 0 ? 'red' : 'blue'; @@ -191,9 +190,10 @@ AFRAME.registerComponent('beat-loader', { generateWall: function (wallInfo) { var el = this.el.sceneEl.components.pool__wall.requestEntity(); var speed = this.data.beatSpeed; - var durationMs; + if (!el) { return; } - durationSeconds = 60 * (wallInfo._duration / this.bpm); + + const durationSeconds = 60 * (wallInfo._duration / this.bpm); el.setAttribute('wall', 'speed', speed); el.object3D.position.set( this.horizontalPositions[wallInfo._lineIndex], diff --git a/src/components/beat.js b/src/components/beat.js index da22a93..b301065 100644 --- a/src/components/beat.js +++ b/src/components/beat.js @@ -128,8 +128,6 @@ AFRAME.registerComponent('beat', { initColliders: function () { var data = this.data; - var i; - var size; var hitColliderConfiguration = { position: {x: 0, y: data.size / 2, z: 0}, size: {width: data.size, height: data.size / 5.0, depth: data.size} @@ -251,13 +249,9 @@ AFRAME.registerComponent('beat', { var coplanarPoint; var cutThickness = this.cutThickness = 0.02; var direction = this.cutDirection; - var focalPoint; - var i; var leftBorderInnerPlane = this.leftBorderInnerPlane; var leftBorderOuterPlane = this.leftBorderOuterPlane; var leftCutPlane = this.leftCutPlane; - var parallelPlane2; - var parallelPlane; var planeGeometry; var planeMesh; var rightBorderInnerPlane = this.rightBorderInnerPlane; @@ -307,7 +301,7 @@ AFRAME.registerComponent('beat', { planeGeometry.lookAt(rightBorderOuterPlane.normal); planeGeometry.translate(coplanarPoint.x, coplanarPoint.y, coplanarPoint.z); - parallelPlaneMesh = new THREE.Mesh(planeGeometry, parallelPlaneMaterial); + const parallelPlaneMesh = new THREE.Mesh(planeGeometry, parallelPlaneMaterial); this.el.sceneEl.setObject3D('planeParallel', parallelPlaneMesh); } diff --git a/src/components/cursor-mesh.js b/src/components/cursor-mesh.js index 9edbaa7..94aa693 100644 --- a/src/components/cursor-mesh.js +++ b/src/components/cursor-mesh.js @@ -19,11 +19,8 @@ AFRAME.registerComponent('cursor-mesh', { var cursor; var cursorEl = this.data.cursorEl; var el = this.el; - var i; var intersection; var intersectedEl; - var intersectionPoint; - var object3D = this.el.object3D; var scenePivotEl = this.scenePivotEl; if (!this.data.active) { return; } diff --git a/src/components/materials.js b/src/components/materials.js index e15208e..515306a 100644 --- a/src/components/materials.js +++ b/src/components/materials.js @@ -13,6 +13,8 @@ AFRAME.registerComponent('materials', { }, update: function () { - this.el.object3D.traverse(o => o.material = this.system[this.data]); + this.el.object3D.traverse(o => { + o.material = this.system[this.data] + }); } }); diff --git a/src/components/menu-controls.js b/src/components/menu-controls.js index f13fe8e..91dbca3 100644 --- a/src/components/menu-controls.js +++ b/src/components/menu-controls.js @@ -15,7 +15,6 @@ AFRAME.registerComponent('menu-controls', { }, init: function () { - const data = this.data; const el = this.el; results = document.getElementById('searchResultList').children; diff --git a/src/components/search-thumbnail-atlas.js b/src/components/search-thumbnail-atlas.js index b211f17..6f53045 100644 --- a/src/components/search-thumbnail-atlas.js +++ b/src/components/search-thumbnail-atlas.js @@ -44,7 +44,6 @@ AFRAME.registerComponent('search-thumbnail-atlas', { update: function () { var el = this.el; - var data = this.data; const results = el.sceneEl.systems.state.state.searchResultsPage; for (let i = 0; i < results.length; i++) { diff --git a/src/components/search.js b/src/components/search.js index 4b44c8a..cf9672b 100644 --- a/src/components/search.js +++ b/src/components/search.js @@ -36,6 +36,7 @@ AFRAME.registerComponent('search', { this.queryObject.query = query; algolia.search(this.queryObject, (err, content) => { // Cache popular hits. + if (err) { console.error(err); } if (!query) { this.popularHits = content.hits; } this.eventDetail.results = content.hits; this.el.sceneEl.emit('searchresults', this.eventDetail); diff --git a/src/components/song-preview.js b/src/components/song-preview.js index 267845a..364ac18 100644 --- a/src/components/song-preview.js +++ b/src/components/song-preview.js @@ -218,7 +218,7 @@ AFRAME.registerComponent('song-preview-system', { } } if (!index) { return; } - this.preloadQueue.splice(i, 1); + this.preloadQueue.splice(index, 1); } }); diff --git a/src/components/song.js b/src/components/song.js index 88e16e0..8f381cf 100644 --- a/src/components/song.js +++ b/src/components/song.js @@ -32,8 +32,6 @@ AFRAME.registerComponent('song', { }, update: function (oldData) { - var audio = this.audio; - var el = this.el; var data = this.data; // Game over, slow down audio, and then stop. diff --git a/src/components/trail.js b/src/components/trail.js index 8842864..63ba8da 100644 --- a/src/components/trail.js +++ b/src/components/trail.js @@ -7,7 +7,6 @@ AFRAME.registerComponent('trail', { init: function () { var geometry = this.geometry = new THREE.BufferGeometry(); - var steps = 10; var maxPoints = this.maxPoints = 12; var vertices = this.vertices = new Float32Array(36 * maxPoints); var colors = this.colors = new Float32Array(48 * maxPoints); @@ -81,18 +80,15 @@ AFRAME.registerComponent('trail', { var segments = this.segments; var dx = 2 / segments; var colors = this.colors; - var bottomLayer; var vertices = this.vertices; - var uvs = this.uvs; - var indexOffset; var color = this.bladeColor; if (this.layers >= this.maxLayers) { this.layers = 0; } - bottomLayer = this.layers * length; + const bottomLayer = this.layers * length; length = bottomLayer + length; - indexOffset = this.layers * segments * 18; - colorOffset = this.layers * segments * 24; + const indexOffset = this.layers * segments * 18; + const colorOffset = this.layers * segments * 24; for (var i = 0; i < segments; ++i) { vertices[indexOffset + 18 * i] = startX + i * dx; diff --git a/src/lib/soundpool.js b/src/lib/soundpool.js index 3fc7e3e..b069820 100644 --- a/src/lib/soundpool.js +++ b/src/lib/soundpool.js @@ -1,6 +1,6 @@ +/* global Audio */ module.exports = function SoundPool (src, volume) { var currSound = 0; - var i; var pool = []; var sound; diff --git a/src/state/index.js b/src/state/index.js index 47f575e..cdc66b2 100644 --- a/src/state/index.js +++ b/src/state/index.js @@ -1,7 +1,7 @@ +/* global localStorage */ var utils = require('../utils'); const challengeDataStore = {}; -const hasInitialChallenge = !!AFRAME.utils.getUrlParameter('challenge'); const SEARCH_PER_PAGE = 6; const SONG_NAME_TRUNCATE = 24; const SONG_SUB_NAME_TRUNCATE = 32; @@ -142,7 +142,7 @@ AFRAME.registerState({ computeMenuSelectedChallengeIndex(state); }, - menuchallengeunselect: () => { + menuchallengeunselect: state => { state.menuSelectedChallenge.id = ''; }, @@ -286,7 +286,7 @@ function computeSearchPagination (state) { truncate(state.search.results[i].songSubName, SONG_SUB_NAME_TRUNCATE) + '\n'; } - for (i = 0; i < state.searchResultsPage.length; i++) { + for (let i = 0; i < state.searchResultsPage.length; i++) { state.searchResultsPage[i].index = i; }