From d881f3aa0bb74578687fc12a2a3d49079f941d5e Mon Sep 17 00:00:00 2001
From: Kevin Ngo <me@ngokevin.com>
Date: Fri, 19 Oct 2018 04:14:40 -0700
Subject: [PATCH] factor in y position beat sound, tweak detune more

---
 src/components/beat-hit-sound.js | 26 +++++++++++++++++++++-----
 1 file changed, 21 insertions(+), 5 deletions(-)

diff --git a/src/components/beat-hit-sound.js b/src/components/beat-hit-sound.js
index 55602b9..ba66bba 100644
--- a/src/components/beat-hit-sound.js
+++ b/src/components/beat-hit-sound.js
@@ -1,6 +1,10 @@
 var audioContext = new window.AudioContext();
 var sourceCreatedCallback = null;
 
+const LAYER_BOTTOM = 'bottom';
+const LAYER_MIDDLE = 'middle';
+const LAYER_TOP = 'top';
+
 // Allows for modifying detune. PR has been sent to three.js.
 THREE.Audio.prototype.play = function () {
   if (this.isPlaying === true) {
@@ -33,8 +37,6 @@ THREE.Audio.prototype.play = function () {
  * Beat hit sound using positional audio and audio buffer source.
  */
 AFRAME.registerComponent('beat-hit-sound', {
-  dependencies: ['sound__beathit'],
-
   init: function () {
     this.currentBeatEl = null;
     this.currentCutDirection = '';
@@ -61,12 +63,26 @@ AFRAME.registerComponent('beat-hit-sound', {
   },
 
   sourceCreatedCallback: function (source) {
-    source.detune.setValueAtTime(0, 0);
+    // Pitch.
+    const layer = this.getLayer(this.currentBeatEl.object3D.position.y);
+    if (layer === LAYER_BOTTOM) {
+      source.detune.setValueAtTime(-400, 0);
+    } else if (layer === LAYER_TOP) {
+      source.detune.setValueAtTime(400, 0);
+    }
+
+    // Inflection.
     if (this.currentCutDirection === 'down') {
-      source.detune.linearRampToValueAtTime(-200, 1.5);
+      source.detune.linearRampToValueAtTime(-400, 1);
     }
     if (this.currentCutDirection === 'up') {
-      source.detune.linearRampToValueAtTime(200, 1.5);
+      source.detune.linearRampToValueAtTime(400, 1);
     }
+  },
+
+  getLayer: function (y) {
+    if (y === 1) { return LAYER_BOTTOM; }
+    if (y === 1.70) { return LAYER_TOP; }
+    return LAYER_MIDDLE;
   }
 });