Give AI a Sound Cue when an Antimov board is inserted (#32625)

* Subversion Board Insertion Audio Notification

Add Subversion flag and SubversionSound to SiliconLawProviderComponent

Add new Method (OnSubversionInserted)
to SiliconLawSystem to handle a Subversive
SiliconLawProviderComponent and play it's SubversionSound

Add Check for Subversive law provider to OnUpdaterInsert that
calls OnSubversionInserted if the SiliconLawProviderComponent is
Subversive

* Fix subversion Sound

- Change out Weh sound used to test that subversion sounds can be
changed by prototype for a a not yet present Antimov subversion sound

* Make it not just subversive

- Remove OnSubversionInserted and move the MindPlaySound in the
OnUpdaterInsert so long as LawUploadSound exists

- Modify SubversionSound into LawUploadSound

- Remove the Subversion flag

- Just use emagged_borg.ogg until the better one is made

* Remove errant spaces and a errant namespace

* CR Fixes - Add generic Lawboard insert cue

- Combine the If statements per /pull/32625#discussion_r1786926400
inside OnUpdaterInsert

- Remove the ViewVariables(VVAccess.ReadWrite) per
pull/32625#discussion_r1786924433

- Add Cryo_warning.ogg from TGStation, the sound utilized for Law Upload
cue, Attribution.

* CR Add a placeholder Antimov notification sound

- Add a new sound kitbashed from the cryo_sound used for uploading
and the emagged noise

* Add self referential source attribution

- also fix an errant space

* Add more bespoke Sound by ps3moira + attributions
This commit is contained in:
Zachary Higgs
2024-10-17 00:41:06 -03:00
committed by GitHub
parent fae5c89ef7
commit 79a23d3e0b
7 changed files with 21 additions and 0 deletions

View File

@@ -293,6 +293,8 @@ public sealed class SiliconLawSystem : SharedSiliconLawSystem
while (query.MoveNext(out var update))
{
SetLaws(lawset, update);
if (provider.LawUploadSound != null && _mind.TryGetMind(update, out var mindId, out _))
_roles.MindPlaySound(mindId, provider.LawUploadSound);
}
}
}

View File

@@ -1,4 +1,5 @@
using Robust.Shared.Prototypes;
using Robust.Shared.Audio;
namespace Content.Shared.Silicons.Laws.Components;
@@ -20,4 +21,12 @@ public sealed partial class SiliconLawProviderComponent : Component
/// </summary>
[DataField, ViewVariables(VVAccess.ReadWrite)]
public SiliconLawset? Lawset;
/// <summary>
/// The sound that plays for the Silicon player
/// when the particular lawboard has been inserted.
/// </summary>
[DataField]
public SoundSpecifier? LawUploadSound = new SoundPathSpecifier("/Audio/Misc/cryo_warning.ogg");
}

View File

@@ -18,3 +18,7 @@
license: "CC-BY-SA-3.0"
copyright: "Made by @ps3moira on github"
source: https://www.youtube.com/watch?v=4-R-_DiqiLo
- files: ["silicon_lawboard_antimov.ogg"]
license: "CC-BY-SA-3.0"
copyright: "Made by @ps3moira on Discord for SS14"
source: "https://www.youtube.com/watch?v=jf1sYGYVLsw"

View File

@@ -28,6 +28,11 @@
copyright: "Taken from TG station."
source: "https://github.com/tgstation/tgstation/blob/2f63c779cb43543cfde76fa7ddaeacfde185fded/sound/effects/ratvar_reveal.ogg"
- files: ["cryo_warning.ogg"]
license: "CC-BY-SA-3.0"
copyright: "Taken from TG station."
source: "https://github.com/tgstation/tgstation/blob/00cf2da5f785c110b9930077b3202f1a4638e1fd/sound/machines/cryo_warning.ogg"
- files: ["epsilon.ogg"]
license: "CC-BY-SA-3.0"
copyright: "Made by dj-34 (https://github.com/dj-34)"

Binary file not shown.

View File

@@ -239,6 +239,7 @@
state: std_mod
- type: SiliconLawProvider
laws: AntimovLawset
lawUploadSound: /Audio/Ambience/Antag/silicon_lawboard_antimov.ogg
- type: entity
id: NutimovCircuitBoard