Made the SpeciesChange mutation no longer persist.
There was an issue where swabbing a mutated plant species: I.e Blood Tomato to a regular Tomato sapling would transfer the species mutation. It would not actually get the effect, which is probably why it went under the radar. This change makes it so that the SpeciesChange mutation cannot be transferred via swabbing.
Instead of each mutation being a flag that gets checked at some unique point in BotanySystem somewhere, they're now EntityEffects that get applied when the mutation occurs and when produce is harvested. One new list was added to SeedData so that multiple other fields could be removed.
All the non-stat-change mutations that have been rolled are added to the Mutations list, and get applied to the plant when the mutation occurs or when a seed with the mutation is planted. Produce get mutations applied at harvest if they apply to the produce, and carry all of the plant's mutations over as a seed. This gets rid of the one-off checks for things like Slippery, Bioluminescent, Sentient, etc.
The base odds of a mutation applying should be equal to the odds of the original mutation check. It pretended to have 1 bit flip (on averge) per mutation power, and odds of each mutation was the odds of one of its bit being flipped (1 /275 * bits). The 'thermometer code' applied for numbers will be replaced with simple random rolls, as both average out to the middle value. The new checks are much easier to understand and don't obfuscate the actual changes of something happening behind 3 layers of math. The biggest player-facing change is that Potency will be able to get over 65 significantly more often than it did in the previous system, but it will be just as common to get low values as high ones.
Mutation definitions have been moved to a .yml file. These include the odds per tick per mutagen strength of that mutation applying that tick, the effect applied, if it applies to the plant and/or its produce. This makes mutations simpler to add and edit.
This PR is limited specifically to the mutation logic. Improving other aspects of the system will be done in other PRs per the design document. Mutations was chosen first because its got the largest amount of one-off checks scattered all over that could be consolidated. Once this is merged, mutations could be contributed to the codebase with minimal extra work for later botany refactor PRs.
* tea plant, blumpkin
* fix linter
* fix tests pls
* bloompkin
* forgor rsi
* work please
* WORK PLEASE
* migration of the blumpkins
* it is now glumpkin
* lowercase
* uppercase
* adjust values and fix blorbo
wtf when did blumpkin donut turn into blorbo donut what
* fix test
* update
* fix stupid mistake
* Update meta.json
* totally not a webedit
* not a webedit 2
* nitpicks
* rainbow weed
* Lipolicide
* psicodine + mannitol
* happiness
* ground + dried + smokables
* damn you notepad++
* fix
WHY NOT TELL ME ALL THE PROBLEMS AT THE SAME TIME!!!
* work
* work i beg you
* recipe good
* possibly fix merge conflict
* remove reagents
* YAML Linter now validates invalid fields in server-only and client-only components
* Update to change in engine PR
* Use reflection manager to get the lists of client/server assemblies.
Also made it use a hashset on type instead of the previous code.
* I'm dumb my bad.
* Fix 2 errors that snuck through, showing why we need this.
---------
Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
* Chem 1984 phase 1
* Chem 1984 phase 2
* Notification on species mutation
* Plant yml balancing
* Better localization
* First version of reagent list
* Revert "Better localization"
nvm
This reverts commit bab87cb1bd58523164d306dccaefc1ac5c6b64ad.
* cooler reagents and no more popups
* :trollface:
* I’m blind
* Add cotton plant
* Adddescription and tag to cotton bal allow moth eat it
* Fix typo. Add cotton seed into MegaSeed
* Fix typo
* Fix typo
* Fix cottonbol component typo
* Fix the amount of cotton that bol gives
* Adding correct component to make cotton bol edible
* Change cotton bol parent to see if it is edible
* Adding flavor to cotton bol, and fix typo
* Replace image
* fixing plant image position
* Increase the Megaseed restock crate price to avoid money farming loop hole
* Add Pea Plants
* Pea soup
* Update flavor-profiles.ftl
* Update seeds.yml
* Add seeds to vendors
* Make things more expensive to fix free money exploit
* Update textures
* Revert "Update textures"
This reverts commit b1b7046504afc7468742b0722f601d98684a1c89.
Vines dont grow straight into the air.
* Shift up 4 pixels
* Fuck autofix conflitcs
* Shift up 3 more pizels
* I finally got byond working so I made sure they were EXACTLY the same
* Address Reviews? I think?
---------
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
* Pumpkin textures
* Pumpkin prototypes
* Jack o lantern prototypes and pumpkin cake
* Finishing touches
* Arbitrageloose
* Restore old pumpkin helmet sprites (God I hope it works)
* Add berries
* Berry recipes
* Add bungo fruit
* yml tweaks
* yummy poisonous pits
* Technically it's a seed
* Revert "Technically it's a seed"
This reverts commit be892cf119c1e733ac2922b878aaa476f435152a.
Slapping the seed component onto it led to unforeseen consequences, and I don't want to mess with the seed system for a mostly useless gimmick.
* Revert 2 Electric Boogaloo
This reverts commit 2c4fb34250e9369085d49e730de3dab0e077b687.
* Small rewording
* Cocoa balancing
* Oops
* Even more consumption
* Revert "Even more consumption"
This reverts commit 94ae0eca0ba1b4a55913f92519e1354b77e70734.
Oops forgot a file
* Believe it or not, more nutrient consumption
* Buff ez nutrient and l4z
* Add left 4 zed to emagged nutrimax just because
* Change some thresholds
* Make the water consumption actually influenced by the seed's water consumption value
* Tweak default water and nutrient consumption
* Composting plants works now
* Tweak seeds YML, add ez nutrient bottle to Nutrimax
* Increase default nutrient consumption a bit
* Cabbage
That's it, just cabbage.
* Up RestockSeed Cargo price.
2000 -> 2100
* Coleslawn, Caesar and Kimchi.
Requires red onions so I also added it to the list.
* Update Resources/Prototypes/Recipes/Cooking/meal_recipes.yml
Fix kimchi's incorrect name.
Co-authored-by: lapatison <100279397+lapatison@users.noreply.github.com>
---------
Co-authored-by: lapatison <100279397+lapatison@users.noreply.github.com>
