more linting, lots of undefined vars or unused vars

This commit is contained in:
Kevin Ngo
2018-10-13 17:26:03 -07:00
parent e94ab73212
commit 672474587b
12 changed files with 16 additions and 30 deletions

View File

@@ -161,7 +161,6 @@ AFRAME.registerComponent('beat-loader', {
return function (noteInfo) {
var beatEl;
var color;
var orientation;
var type = noteInfo._cutDirection === 8 ? 'dot' : 'arrow';
color = noteInfo._type === 0 ? 'red' : 'blue';
@@ -191,9 +190,10 @@ AFRAME.registerComponent('beat-loader', {
generateWall: function (wallInfo) {
var el = this.el.sceneEl.components.pool__wall.requestEntity();
var speed = this.data.beatSpeed;
var durationMs;
if (!el) { return; }
durationSeconds = 60 * (wallInfo._duration / this.bpm);
const durationSeconds = 60 * (wallInfo._duration / this.bpm);
el.setAttribute('wall', 'speed', speed);
el.object3D.position.set(
this.horizontalPositions[wallInfo._lineIndex],

View File

@@ -128,8 +128,6 @@ AFRAME.registerComponent('beat', {
initColliders: function () {
var data = this.data;
var i;
var size;
var hitColliderConfiguration = {
position: {x: 0, y: data.size / 2, z: 0},
size: {width: data.size, height: data.size / 5.0, depth: data.size}
@@ -251,13 +249,9 @@ AFRAME.registerComponent('beat', {
var coplanarPoint;
var cutThickness = this.cutThickness = 0.02;
var direction = this.cutDirection;
var focalPoint;
var i;
var leftBorderInnerPlane = this.leftBorderInnerPlane;
var leftBorderOuterPlane = this.leftBorderOuterPlane;
var leftCutPlane = this.leftCutPlane;
var parallelPlane2;
var parallelPlane;
var planeGeometry;
var planeMesh;
var rightBorderInnerPlane = this.rightBorderInnerPlane;
@@ -307,7 +301,7 @@ AFRAME.registerComponent('beat', {
planeGeometry.lookAt(rightBorderOuterPlane.normal);
planeGeometry.translate(coplanarPoint.x, coplanarPoint.y, coplanarPoint.z);
parallelPlaneMesh = new THREE.Mesh(planeGeometry, parallelPlaneMaterial);
const parallelPlaneMesh = new THREE.Mesh(planeGeometry, parallelPlaneMaterial);
this.el.sceneEl.setObject3D('planeParallel', parallelPlaneMesh);
}

View File

@@ -19,11 +19,8 @@ AFRAME.registerComponent('cursor-mesh', {
var cursor;
var cursorEl = this.data.cursorEl;
var el = this.el;
var i;
var intersection;
var intersectedEl;
var intersectionPoint;
var object3D = this.el.object3D;
var scenePivotEl = this.scenePivotEl;
if (!this.data.active) { return; }

View File

@@ -13,6 +13,8 @@ AFRAME.registerComponent('materials', {
},
update: function () {
this.el.object3D.traverse(o => o.material = this.system[this.data]);
this.el.object3D.traverse(o => {
o.material = this.system[this.data]
});
}
});

View File

@@ -15,7 +15,6 @@ AFRAME.registerComponent('menu-controls', {
},
init: function () {
const data = this.data;
const el = this.el;
results = document.getElementById('searchResultList').children;

View File

@@ -44,7 +44,6 @@ AFRAME.registerComponent('search-thumbnail-atlas', {
update: function () {
var el = this.el;
var data = this.data;
const results = el.sceneEl.systems.state.state.searchResultsPage;
for (let i = 0; i < results.length; i++) {

View File

@@ -36,6 +36,7 @@ AFRAME.registerComponent('search', {
this.queryObject.query = query;
algolia.search(this.queryObject, (err, content) => {
// Cache popular hits.
if (err) { console.error(err); }
if (!query) { this.popularHits = content.hits; }
this.eventDetail.results = content.hits;
this.el.sceneEl.emit('searchresults', this.eventDetail);

View File

@@ -218,7 +218,7 @@ AFRAME.registerComponent('song-preview-system', {
}
}
if (!index) { return; }
this.preloadQueue.splice(i, 1);
this.preloadQueue.splice(index, 1);
}
});

View File

@@ -32,8 +32,6 @@ AFRAME.registerComponent('song', {
},
update: function (oldData) {
var audio = this.audio;
var el = this.el;
var data = this.data;
// Game over, slow down audio, and then stop.

View File

@@ -7,7 +7,6 @@ AFRAME.registerComponent('trail', {
init: function () {
var geometry = this.geometry = new THREE.BufferGeometry();
var steps = 10;
var maxPoints = this.maxPoints = 12;
var vertices = this.vertices = new Float32Array(36 * maxPoints);
var colors = this.colors = new Float32Array(48 * maxPoints);
@@ -81,18 +80,15 @@ AFRAME.registerComponent('trail', {
var segments = this.segments;
var dx = 2 / segments;
var colors = this.colors;
var bottomLayer;
var vertices = this.vertices;
var uvs = this.uvs;
var indexOffset;
var color = this.bladeColor;
if (this.layers >= this.maxLayers) { this.layers = 0; }
bottomLayer = this.layers * length;
const bottomLayer = this.layers * length;
length = bottomLayer + length;
indexOffset = this.layers * segments * 18;
colorOffset = this.layers * segments * 24;
const indexOffset = this.layers * segments * 18;
const colorOffset = this.layers * segments * 24;
for (var i = 0; i < segments; ++i) {
vertices[indexOffset + 18 * i] = startX + i * dx;

View File

@@ -1,6 +1,6 @@
/* global Audio */
module.exports = function SoundPool (src, volume) {
var currSound = 0;
var i;
var pool = [];
var sound;

View File

@@ -1,7 +1,7 @@
/* global localStorage */
var utils = require('../utils');
const challengeDataStore = {};
const hasInitialChallenge = !!AFRAME.utils.getUrlParameter('challenge');
const SEARCH_PER_PAGE = 6;
const SONG_NAME_TRUNCATE = 24;
const SONG_SUB_NAME_TRUNCATE = 32;
@@ -142,7 +142,7 @@ AFRAME.registerState({
computeMenuSelectedChallengeIndex(state);
},
menuchallengeunselect: () => {
menuchallengeunselect: state => {
state.menuSelectedChallenge.id = '';
},
@@ -286,7 +286,7 @@ function computeSearchPagination (state) {
truncate(state.search.results[i].songSubName, SONG_SUB_NAME_TRUNCATE) + '\n';
}
for (i = 0; i < state.searchResultsPage.length; i++) {
for (let i = 0; i < state.searchResultsPage.length; i++) {
state.searchResultsPage[i].index = i;
}