While trying to play a replay I noticed that the replay would freeze
when seeking in some cases. After some debugging, I discovered that two
MIDI renderers had each other as master, which caused an infinite loop
processing MIDI events.
I'm not entirely sure of the sequence of events that leads to this
during replay playback, but I did notice that MIDI render masters are
never set to null. This is in the best case just a memory leak, in the
worst case probably the source of the bug, so... I fixed that.
* Fix disposal unit flush animation
* Revert "Fix disposal unit flush animation"
This reverts commit a596ecfd5f5368f87ef52cfb27884a8e000185c6.
* control by setting layer visibility rather than overwriting
* restore changes
* Add new fields to DeliveryComponent for #36636
* Setting the baseSpesoPenalty for currently available deliveries
* Small fixes
* Basic delivery penalization
* Penalty and reward multiplier calculation in place
Also fixes an issue in SharedCargoSystem when opening a delivery in dev server due to trying to allocate cargo twice.
* Calling penalty no longer happens on opening
* Extract multiplier getting
* Removing unused include
* Changing method description. \n\n Not actually sure what I meant by the first one
* Localising default delivery messages
* Unused include removal
* init or smth
* minor tweaks
* I KEEP MERGE CONFLICTING MYSELF
* comments
* no icon
* slight increase
* slarti changes
* forgot
* stuffs
* yippee
* Locn't
* doc
* partial review
* message
* review
* pain
* stuff
---------
Co-authored-by: Lmorgan89 <billsmith116@gmail.com>
* Add new fields to DeliveryComponent for #36636
* Setting the baseSpesoPenalty for currently available deliveries
* Small fixes
* Basic delivery penalization
* Penalty and reward multiplier calculation in place
Also fixes an issue in SharedCargoSystem when opening a delivery in dev server due to trying to allocate cargo twice.
* Calling penalty no longer happens on opening
* Extract multiplier getting
* Removing unused include
* Changing method description. \n\n Not actually sure what I meant by the first one
* Localising default delivery messages
* Unused include removal
* minor tweaks
* slarti changes
* forgot
* stuffs
* yippee
* Locn't
* doc
* Apply suggestions from code review
---------
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
Co-authored-by: ScarKy0 <scarky0@onet.eu>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* initial commit
* add the shop and make it work
* add existing pai actions to the software shop
* added power monitor app
* killed the power and crew monitor software, too powercreepy
* fix test failures
* fix more test failures
* fix merge conflicts
* code changes to conform with review
* fix unintentional submodule update
* submodule update
* remove unused currency prototype ref
---------
Co-authored-by: archrbx <punk.gear5260@fastmail.com>
