* I dunno, break shit I guess.
* Actually fix some shit for once.
* test flakey or me flakey?
* Test were not flakey, they just didnt make any sense anymore.
* more stationy tests
* undo abuncha shit I can set in yml instead
* forgor an assert
* unneeded usings
* 1984
* I made github angy
* yoink
* the end is never the end is never the end is never the end is never the end is never the end is never the
* Im going to commit sudoku
* tweak(medical): Reduce chemist slots
* tweak(medical): roundstart chemists slot set to 2 on some maps
* tweak(fland): Chemist slots to 3
fland is target to 80-100 players
* Add robo control comp, also de-reinforce a lot of walls.
* Add Accordia Evac shuttle for Oasis.
* Revert "Add robo control comp, also de-reinforce a lot of walls."
This reverts commit b6be6b616aa9732b81e02bed76e3c9ae103cf7cb.
* Revert "Buff the AME until somebody fixes engineering" (#28419)
* Automatic changelog update
* hand teleport portals now may start in the same grid. (#28556)
* Microwave recipes now uses stacktype id instead of entity prototype id for stacked entities (#28225)
* Automatic changelog update
* Add "fill level" sprites to mops and damp rag (#28590)
* Automatic changelog update
* Reword some criminal records text (#28597)
* Update criminal-records.ftl
* Update criminal-records.ftl
* Update criminal-records.ftl
* Remove obsolete VisibilitySystem functions (#28610)
Remove obsolete visibility functions
Co-authored-by: plykiya <plykiya@protonmail.com>
* Prayable datafield typo (#28622)
* notifiactionPrefix -> notificationPrefix
* notifiactionPrefix -> notificationPrefix
* Update engine to v224.1.0 (#28624)
* Use dummy sessions in NukeOpsTest (#28549)
* Add dummy sessions
* Update NukeOpsTest
* Fix PvsBenchmark
* Update engine to v224.1.1 (#28632)
* Add Job preference tests (#28625)
* Misc Job related changes
* Add JobTest
* A
* Aa
* Lets not confuse the yaml linter
* fixes
* a
* Add logs that provide session to player admin logs (#28628)
* Cluster Update (#28627)
done here
* Automatic changelog update
* minor banner changes (#28636)
* minor banner changes
* Uhrmm actchually it's you're, not your
* Update banners.yml
props Hyenh
* Revenant spell catalog locale (#28638)
locale
* Make cuff default range again (#28576)
* Make cuff default range again
* uncuff distance
* how about ONE
---------
Co-authored-by: plykiya <plykiya@protonmail.com>
* Automatic changelog update
* Machine-code cleanup (#28489)
* Make Projectiles Only Hit a Variety of Station Objects Unless Clicked on (#28571)
* Automatic changelog update
* Fix Smoke-grenade.ogg not being mono (#28593)
* Fix Cigars Sprites + YAML fix for Inhand unlit cigars/cigs (#28641)
* Automatic changelog update
* Clean up Eva and Hardsuit helm yml + Lets atmos firesuit helm work as a BreathMask (#28602)
* Shifts borgs hats to the right a bit (#28600)
* Fix mouse inhands (#28623)
* Adjust some touch reaction damage levels (#28591)
* Automatic changelog update
* Add closing storage UIs to StorageInteractionTest (#28633)
* Update rules (#28452)
* Add support for LocalizedDatasets to RandomMetadata (#28601)
* Fix Admin Object tab sorting and search (#28609)
* Automatic changelog update
* Internals are kept on as long as any breathing tool is on (#28595)
* Automatic changelog update
* Convert rules to use guidebook parsing (#28647)
* Gives Insulation and NoSlip to all bots (#28621)
* Gives Insulation and NoSlip to all bots
* remove NoSlip from children
* Automatic changelog update
* Nerfs welderbombing (#28650)
nerf welderbombing
* Automatic changelog update
* Give jobs & antags prototypes a guide field (#28614)
* Give jobs & antags prototypes a guide field
* A
* space
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
* Add todo
* Fix merge errors
---------
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
* Automatic changelog update
* Fix typo in Space Law's restricted gear (#28668)
This typo was included in the wiki as well.
Reported-by: Bobberson in the Discord
* Automatic changelog update
* fixed "silicones" typo in new rules (#28671)
fixed all appearances of silicone where it should have been silicon
* fix janitor not spawning with a survival box (#28669)
hi
* Automatic changelog update
* Fix typo in slime naming conventions (#28682)
* Flatpacker fixes (#28417)
* Return medicine recipe solid material costs to 1 (#28679)
Set material costs of medicine recipes to 1
* Automatic changelog update
* Update Core (#28689)
add
* Fixed the guidebook listing every single rule (#28680)
* Well i tried this way
* New approach (start)
* Did it
* makes spacelaw available, put it under sec
* Automatic changelog update
* rule fixes first pass (#28701)
update
* Add JobRequirementOverride prototypes (#28607)
* Add JobRequirementOverride prototypes
* a
* invert if
* Add override that takes in prototypes directly
* Tweak chapel salvage wreck (#28703)
add
* Fixes client having authority over rules popup cvars (#28655)
* Fixes client having authority over rules popup cvars
* Delete duplicate migration
* Pre-update
* Post-update
* Add locale support for booze and soda jugs labels (#28708)
* Swap some InRangeUnobstructed for InRangeUnoccluded (#28706)
Swap InRangeUnobstructed to InRangeUnoccluded
Co-authored-by: plykiya <plykiya@protonmail.com>
* Automatic changelog update
* Ports the singularity's values from vgstation (#28720)
* ports the singularity values from vgstation
* guidebook fix
* 5000 energy level 6 singulo
* Fix action icons when dragging an active action to another slot (#28692)
* Add DoPopup data field to OnUseTimerTrigger (#28691)
* Dropping Corpses Devoured by Space Dragons on Gib/Butcher. (#28709)
* Update DevourSystem.cs
* Update DevourSystem.cs
* Update Content.Server/Devour/DevourSystem.cs
---------
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
* Automatic changelog update
* Improve grammar of various petting messages (#28715)
Improve grammar of various petting message
* Fix DamageOtherOnHit.OnDoHit when the target is terminating or deleted (#28690)
* Update Core (#28735)
add
* Fix flatpacker (#28736)
* Fix flatpacker
* a
* rn, atp (#28674)
* Update speech-chatsan.ftl
* Update word_replacements.yml
* Atm-at the moment
* Atm
* Update Resources/Locale/en-US/speech/speech-chatsan.ftl
* Update Resources/Prototypes/Accents/word_replacements.yml
---------
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
* Add loadout group check for role proto (#28731)
MFW same bug twice at 2 layers because I'm stupid.
* Automatic changelog update
* Try fix RGBee (#28741)
* Automatic changelog update
* Ensure packager creates a release folder (#28426)
I was screaming at the github actions runner before i noticed something i had done before caused me to never have a release folder and thus fail.
* allow ' in character names (#28652)
* Automatic changelog update
* Make freeze, freeze & mute, and unmute verbs work on disconnected players. (#28664)
* Automatic changelog update
* fix singulo decay (#28743)
* Automatic changelog update
* Don't use invalid defaults for loadouts (#28729)
At the time it made more sense but now with species specific stuff it's better to have nothing.
* Maybe fix invalid loadout prototypes (#28734)
* Maybe fix invalid loadout prototypes
So if we have existing data SetDefault is not normally called iirc. So what I think is happening is that if we have old loadout groups that get saved to DB and loaded these get dropped entirely and nothing is used to replace the group unless the person specifically looks at their loadout.
Need someone affected to send me their loadout to confirm it's fixed.
* Better fix
* Automatic changelog update
* Fix null ref exception in PrayerSystem (#28712)
* Fix null ref exception in PrayerSystem
* Also check that prayable ent/comp still exist
* Guidebook Updates for the Amateur Spessman (#28603)
* Created NewPlayer.xml
* Created NewPlayer.yml and added it to guides.ftl
* shifted some controls from Space Station 14 to New? Start here!, as well as made a character creation xml to be written later
* switched some stuff between the New? entry and the Space Station 14 entry
* Made everything so nice!!!!!!!!!!!!!!
* fixed formatting inconsistencies
* added a How to use this guidebook section
* build correction and guidebook clarification for other servers
* wrote character creation ig probs fo shizzle
* added new terms to the glossary and alphabetized it
* meh this seems important enough to add
* okay no more shitsec bad idea
* I HATED Roleplaying.xml ANYWAY!!!
* I REALLY REALLY HATED IT ACTUALLYLLL
* Moved Controls and Radio into newplayer.yml, making meta.yml and radio.yml obsolete
* Separated the character creation bits that are just cosmetic from the ones that matter
* also put all the related new player xml files in their own folder
* expanded Radio.xml, kinda fixed survival.xml
* removed the line that mighta maybe sorta possibly could encourage self antag
* thought about this randomly but ICK OCK
* talking is no longer a key part of this game
* moves stuff around, a lot of stuff. basically moves everything but the jobs themselves around
* ah probably should make sure this works first also me when i lie on the internet
* don't be such a grammar nukie
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
* okay nevermind that's justified
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
* prepare. it is coming. the great reorganization...
* yesyes that's all well and goo- THE REORG IS COMING. THE REORG IS COMING. WAKE UP.
* rename that real quick
* step one begins. first, consolidate existing service entries into their own yaml. this makes botany.yml obsolete.
* update shiftandcrew.yml to only have departments as children also fuck it alphabetization
* consolidated salvage into cargo
* made a new entry for command
* gave salvage a home and service an existence
* made some XML files to be filled out later
* quick rename...
* took some stuff from Intro.txt and i think Gameplay.txt and put it in NewPlayer.xml
* The Great Writing about Departments (25XX, black and white)
* added a bunch of links everywhere
* biochemical is no longer a thing
* service formatinaaaaaaa
* shiny...,,,,,,,,, colo(u)rz..,,,,,,,,,,,,,
* let's get that fixed
* second time i made a typo there as well
* we hate fun around here
* grammar?!???/
* various fixes and more linkings
* oops
* wewlad lol!!
---------
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
Co-authored-by: AJCM <AJCM@tutanota.com>
* Automatic changelog update
* Add suffixes to excap survival boxes (#28755)
Update emergency.yml
* Add Jani lobby background (#28724)
* Add jani lobby background
* Actually make new lobby screen functional
* Fix license
* Automatic changelog update
* Strip markdown from silicon laws before saying them (#28596)
* saltern update (#28773)
Co-authored-by: deltanedas <@deltanedas:kde.org>
* revert Tornado regex
* Update HumanoidCharacterProfile.cs
* Update arenas.yml
* test
* fix locale
* Update options-menu.ftl
* Update species-names.ftl
* Update debug.yml
* aaaaaa
---------
Co-authored-by: Moony <moony@hellomouse.net>
Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com>
Co-authored-by: icekot8 <93311212+icekot8@users.noreply.github.com>
Co-authored-by: blueDev2 <89804215+blueDev2@users.noreply.github.com>
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
Co-authored-by: TsjipTsjip <19798667+TsjipTsjip@users.noreply.github.com>
Co-authored-by: Plykiya <58439124+Plykiya@users.noreply.github.com>
Co-authored-by: plykiya <plykiya@protonmail.com>
Co-authored-by: Leon Friedrich <60421075+ElectroJr@users.noreply.github.com>
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
Co-authored-by: Boaz1111 <149967078+Boaz1111@users.noreply.github.com>
Co-authored-by: Hmeister-real <118129069+Hmeister-real@users.noreply.github.com>
Co-authored-by: lapatison <100279397+lapatison@users.noreply.github.com>
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
Co-authored-by: Cojoke <83733158+Cojoke-dot@users.noreply.github.com>
Co-authored-by: DrSmugleaf <10968691+DrSmugleaf@users.noreply.github.com>
Co-authored-by: Ps3Moira <113228053+ps3moira@users.noreply.github.com>
Co-authored-by: Verm <32827189+Vermidia@users.noreply.github.com>
Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>
Co-authored-by: Repo <47093363+Titian3@users.noreply.github.com>
Co-authored-by: Flareguy <78941145+Flareguy@users.noreply.github.com>
Co-authored-by: Thomas <87614336+Aeshus@users.noreply.github.com>
Co-authored-by: Moomoobeef <62638182+Moomoobeef@users.noreply.github.com>
Co-authored-by: Mr. 27 <45323883+Dutch-VanDerLinde@users.noreply.github.com>
Co-authored-by: Ubaser <134914314+UbaserB@users.noreply.github.com>
Co-authored-by: AJCM-git <60196617+AJCM-git@users.noreply.github.com>
Co-authored-by: lzk <124214523+lzk228@users.noreply.github.com>
Co-authored-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: MerrytheManokit <167581110+MerrytheManokit@users.noreply.github.com>
Co-authored-by: Vasilis <vasilis@pikachu.systems>
Co-authored-by: Whisper <121047731+QuietlyWhisper@users.noreply.github.com>
Co-authored-by: nikthechampiongr <32041239+nikthechampiongr@users.noreply.github.com>
Co-authored-by: UBlueberry <161545003+UBlueberry@users.noreply.github.com>
Co-authored-by: AJCM <AJCM@tutanota.com>
Co-authored-by: Psychpsyo <60073468+Psychpsyo@users.noreply.github.com>
Co-authored-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
* Add map Oasis
* integration test fix
* psych job
* 1984 an invalid component
* address reviews
* address reviews, touch ups.
* tiny feexes
* move a tree
* Actually put it in the active maps pool.
* minor tweeks
* tweek some door accesses.
* add extra lawyer, make evac the right docking arrangement.
* Address the small things, fix cryopods, make perma huge.
* Fix some small things in the new perma.
* Improve perma spacing resiliancy... maybe.
* burn the invalids
* Pray to the Sloth gods that painters arent cooked.
* rearrange some buttons
* fix fax names and add a genedrobe.
* Housekeeping
* fix some stuff I thought I already fixed
* wood benches
* Some under door tiles, a couple missing decals.
* one pipe got brokey. feexit!
* astrograsses and lathe to cargo
* N2 lockers, minor things.
* cap laser to case
* GridFill the briggle so it feels better. Some other minor things
* name the Briggle correctly
* Fix for the salvage ice labs map. (#26928)
* done
* more work
* Automatic changelog update
* Update Credits (#26938)
Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com>
* Fix cryostorage identifying unknown characters as captain (#26927)
Fixed cryostorage getting captain's record for unknown jobs.
Also localized Unknown job string.
* Automatic changelog update
* Fixed Honkbot/jonkbot honking like crazy, gave honkbot/jonkbot standard idle ai. (#26939)
* Fixed Honkbot/jonkbot honking like crazy, gave honkbot/jonkbot standard idle ai.
* Update Resources/Prototypes/Entities/Mobs/NPCs/silicon.yml
---------
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
* Automatic changelog update
* Bug fix: Force cancellation of RCD constructions if the construction type is changed (#26935)
Force cancellation of RCD constructions if the construction type is changed
* Fix standart -> standard and dressfilled test fail (#26942)
Fix standart -> standard
* Add Ability to stop sound when MobState is Dead (#26905)
* Add stopsWhenEntityDead to sound components
* Convert component
* Review
* Fix dupe sub
---------
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
* Automatic changelog update
* Fix rockets and lasers looking like they have nothing loaded (#26933)
* Automatic changelog update
* You can now see paper on crates (with color!) (#26834)
* Implement changes on not-cooked branch
* Made it work
* Fix update appearance calls
* Fix extra indents, clean-up code, fix tests hopefully
* Fix hammy cagecrate
* Fix messing up the yml, add artifact crate specific labels back in
* Visual Studio hates yml, sad
* Seperate the colors for cargonia
* sorry json
* make label move with artifact door
* Apply suggestion changes
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
* Fix remaining crate offsets, add a few for livestock and graves (why are you labeling graves) and coffin label sprites (why are you labeling coffins??)
---------
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
* Make UtensilSystem and SharpSystem not run AfterInteract if it has already been handled (#25826)
* Make UtensilSystem and SharpSystem not run AfterInteract if it has already been handled
* merge conflicts
---------
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
* Automatic changelog update
* Add two-message overload to PopupPredicted (#26907)
Added two-message overload to PopupPredicted
* Update submodule to 218.0.0 (#26945)
* Autism pins! (#25597)
* hee hee he ha ha
* added gold varients, forgive me for my spritework
* maints loot, copying from past PRs
* Trying to fix RSI
* speedran these sprites in break time, pictures will be later
* Fixed/Tweaked glows
* consensus
* gregregation
* dam copiryte
* oops i forgot to delete 2 fields hope this works
* Automatic changelog update
* Fix database round start date issues (#26838)
How can ONE DATABASE COLUMN have so many cursed issues I don't know, but it certainly pissed off the devil in its previous life.
The start_date column on round entities in the database was added by https://github.com/space-wizards/space-station-14/pull/21153. For some reason, this PR gave the column a nonsensical default value instead of making it nullable. This default value causes the code from #25280 to break. It actually trips an assert though that's not what the original issue report ran into.
This didn't get noticed on wizden servers because we at some point backfilled the start_date column based on the stored admin logs.
So I change the database model to make this column nullable, updated the C# code to match, and made the existing migration set the invalid values to be NULL instead. Cool.
Wait how's SQLite handle in this scenario anyways? Well actually turns out the column was *completely broken* in the first place!
The code for inserting into the round table was copy pasted between SQLite and PostgreSQL, with the only difference being that the SQLite key manually assigned the primary key instead of letting SQLite AUTOINCREMENT it. And then the code to give a start_date value was only added to the PostgreSQL version (which is actually in the base class already). So for SQLite that column's been filled up with the same invalid default the whole time.
Why was the code manually assigning a PK? I checked the SQLite docs for AUTOINCREMENT[1], and the behavior seems appropriate.
I removed the SQLite-specific code path and it just seems to work regardless. The migration just sets the old values to NULL too.
BUT WAIT, THERE'S MORE!
Turns out just doing the migration on SQLite is a pain in the ass! EF Core has to create a new table to apply the nullability change, because SQLite doesn't support proper ALTER COLUMN. This causes the generated SQL commands to be weird and the UPDATE for the migration goes BEFORE the nullability change... I ended up having to make TWO migrations for SQLite. Yay.
Fixes#26800
[1]: https://www.sqlite.org/autoinc.html
* Fix options menu crashing in replays (#26911)
Not having the nullable set properly is annoying but fixing that would probably be a significant amount of work.
* Greyscale color clothing (#26943)
* greyscales color gloves, color jumpsuits, and shoes
* remove popbob
* fix test fails
* Automatic changelog update
* WT550 Buffs + Burst Mode for WT550 & C-20R (#26886)
* Slightly increased WT550 Firerate, drastically reduced recoil, and given it the option to fire in 5 round bursts.
* Given the C-20 a 5 round burst aswell
* Automatic changelog update
* make holoparasites actually holographic (#26862)
it's over
* Automatic changelog update
* Add character sheets to board game crate (#26926)
add character sheets to board game crate
* Automatic changelog update
* Game server admin API (#26880)
* Reapply "Game server api" (#26871)
This reverts commit 3aee197923.
* Rewrite 75% of the code it's good now
* Wield recoil components (#26915)
* WieldRecoilComponents
* WieldRecoilComponents
* Update Content.Shared/Weapons/Ranged/Components/GunWieldBonusComponent.cs
Co-authored-by: Whisper <121047731+QuietlyWhisper@users.noreply.github.com>
* Update Content.Shared/Weapons/Ranged/Components/GunWieldBonusComponent.cs
---------
Co-authored-by: Whisper <121047731+QuietlyWhisper@users.noreply.github.com>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
* Clown shoes make you waddle, as God intended (#26338)
* Clown shoes make you waddle, as God intended
* OOPS
* Toned down, client system name fix
* Tidy namespacing for @deltanedas
* Refactor to handle prediction better, etc.
* Resolve PR comments.
* Automatic changelog update
* Use round time instead of server time for criminal history (#26949)
make criminal records computer use round time for history instead of the server time
* Rotate and Offset station CCVar nuke (#26175)
* no content
* add noRot to Europa
* bruh. and this
* yay
* fix
* Update debug.yml
---------
Co-authored-by: Boaz1111 <149967078+Boaz1111@users.noreply.github.com>
Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
Co-authored-by: superjj18 <gagnonjake@gmail.com>
Co-authored-by: chromiumboy <50505512+chromiumboy@users.noreply.github.com>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: GreaseMonk <1354802+GreaseMonk@users.noreply.github.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
Co-authored-by: DrSmugleaf <10968691+DrSmugleaf@users.noreply.github.com>
Co-authored-by: Verm <32827189+Vermidia@users.noreply.github.com>
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
Co-authored-by: Terraspark4941 <terraspark4941@gmail.com>
Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
Co-authored-by: Flareguy <78941145+Flareguy@users.noreply.github.com>
Co-authored-by: BramvanZijp <56019239+BramvanZijp@users.noreply.github.com>
Co-authored-by: Mr. 27 <45323883+Dutch-VanDerLinde@users.noreply.github.com>
Co-authored-by: Tyzemol <85772526+Tyzemol@users.noreply.github.com>
Co-authored-by: Froffy025 <78222136+Froffy025@users.noreply.github.com>
Co-authored-by: Whisper <121047731+QuietlyWhisper@users.noreply.github.com>
Co-authored-by: Hannah Giovanna Dawson <karakkaraz@gmail.com>
Co-authored-by: ilya.mikheev.coder <imc-ext+github@ilyamikcoder.com>
